From f1eaa672211b1623e206ae1b0f17b07ae53a7bee Mon Sep 17 00:00:00 2001 From: Felix Held Date: Thu, 18 Feb 2021 20:34:21 +0100 Subject: [PATCH] soc/amd/common/block/data_fabric: add warning about broadcast reads Signed-off-by: Felix Held Change-Id: If1b65ae3dd2b5c8fe7bc29a267d108e4d3a3e567 Reviewed-on: https://review.coreboot.org/c/coreboot/+/50883 Reviewed-by: Jason Glenesk Reviewed-by: Raul Rangel Reviewed-by: Paul Menzel Reviewed-by: Marshall Dawson Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/soc/amd/common/block/data_fabric/data_fabric_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/soc/amd/common/block/data_fabric/data_fabric_helper.c b/src/soc/amd/common/block/data_fabric/data_fabric_helper.c index 27fc03d58c..abb4ba8c3a 100644 --- a/src/soc/amd/common/block/data_fabric/data_fabric_helper.c +++ b/src/soc/amd/common/block/data_fabric/data_fabric_helper.c @@ -23,6 +23,8 @@ static void data_fabric_set_indirect_address(uint8_t func, uint16_t reg, uint8_t uint32_t data_fabric_read32(uint8_t function, uint16_t reg, uint8_t instance_id) { + /* Broadcast reads might return unexpected results when a register has different + contents in the different instances. */ if (instance_id == BROADCAST_FABRIC_ID) return data_fabric_broadcast_read32(function, reg);