From f23c6a8ff5f093476633156d8dff782080335bb0 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Sat, 5 Dec 2020 18:32:05 +0100 Subject: [PATCH] device/azalia_device.c: Clarify comment The `4` here doesn't have to do with the size of u32. Instead, it is because the verb header contains the number of jacks, which is the number of four-verb groups. Change-Id: I3956ce5ec2a7abc29982504cf75b262a1c098af5 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/48352 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Rudolph --- src/device/azalia_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/device/azalia_device.c b/src/device/azalia_device.c index e46c27f7b0..ab370f95d7 100644 --- a/src/device/azalia_device.c +++ b/src/device/azalia_device.c @@ -115,7 +115,8 @@ u32 azalia_find_verb(const u32 *verb_table, u32 verb_table_bytes, u32 viddid, co int idx = 0; while (idx < (verb_table_bytes / sizeof(u32))) { - u32 verb_size = 4 * verb_table[idx + 2]; // in u32 + /* Header contains the number of jacks, aka groups of 4 dwords */ + u32 verb_size = 4 * verb_table[idx + 2]; if (verb_table[idx] != viddid) { idx += verb_size + 3; // skip verb + header continue;