From f2baae3735b86ff14a13728a845bd484aa4caf70 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Thu, 19 Nov 2020 13:09:56 +0100 Subject: [PATCH] soc/intel/common/pmc.c Don't implement a weak function that dies Buildtime failures are better than runtime failures. Change-Id: I5fe4c86a13dbabb839977010f129419e337e8281 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/47752 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/soc/intel/common/block/pmc/pmc.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/src/soc/intel/common/block/pmc/pmc.c b/src/soc/intel/common/block/pmc/pmc.c index d153bc7188..fe4dca6fa4 100644 --- a/src/soc/intel/common/block/pmc/pmc.c +++ b/src/soc/intel/common/block/pmc/pmc.c @@ -8,22 +8,6 @@ #include #include -/* SoC overrides */ - -/* Fill up PMC resource structure inside SoC directory */ -__weak int pmc_soc_get_resources( - struct pmc_resource_config *cfg) -{ - /* no-op */ - return -1; -} - -/* SoC override PMC initialization */ -__weak void pmc_soc_init(struct device *dev) -{ - /* no-op */ -} - static void pch_pmc_add_new_resource(struct device *dev, uint8_t offset, uintptr_t base, size_t size, unsigned long flags)