storm: fix SW_RESET signal polarity
The actual level required to take the ethernet switch out of reset is low, not high. BUG=chrome-os-partner:31780 TEST=with this patch applied, when proto0.2 boots, the ethernet switch's LED blink once, as was the case with proto0. Change-Id: If4004ac5c2dc837270d4cb840d96ce92021d231e Signed-off-by: Patrick Georgi <pgeorgi@chromium.org> Original-Commit-Id: 9fa69d22de901cd0843948de0f95a66a2aa99353 Original-Change-Id: I81eeb73b85cf113709b6d4ac3aa7639a40fa6719 Original-Signed-off-by: Vadim Bendebury <vbendeb@chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/217416 Original-Reviewed-by: David Hendricks <dhendrix@chromium.org> Reviewed-on: http://review.coreboot.org/9121 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
parent
c7bbc04544
commit
f32ef133dd
|
@ -97,11 +97,16 @@ static void deassert_sw_reset(void)
|
|||
if (board_id() == 0)
|
||||
return;
|
||||
|
||||
/* only proto0.2 and later care about this. */
|
||||
/*
|
||||
* only proto0.2 and later care about this. This signal is eventually
|
||||
* driving the ehernet switch reset input, which is active low. But
|
||||
* since this signal gets inverted along the way, the GPIO needs to be
|
||||
* driven low to take the switch out of reset.
|
||||
*/
|
||||
gpio_tlmm_config_set(SW_RESET_GPIO, FUNC_SEL_GPIO,
|
||||
GPIO_PULL_UP, GPIO_4MA, GPIO_ENABLE);
|
||||
|
||||
gpio_set_out_value(SW_RESET_GPIO, 1);
|
||||
gpio_set_out_value(SW_RESET_GPIO, 0);
|
||||
}
|
||||
|
||||
static void mainboard_init(device_t dev)
|
||||
|
|
Loading…
Reference in New Issue