GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/wifi: Fix DSM parsing issue 

commit b6ebcdfde5 restructured
the DSM implementation which resulted in a regression
and DSM values gets filled with junk values.
This CL fixes this issue and passes the right pointer to the dsm
ids structure.

BUG=b:256938177
TEST=Build, boot Nivviks and check if the DSM values are parsed
correctly in the  SSDT dump.

Signed-off-by: Meera Ravindranath <meera.ravindranath@intel.com>
Change-Id: I88782b0b7dde1fca0230472a38628e82dfd9c26c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69427
Reviewed-by: Haribalaraman Ramasubramanian <haribalaraman.r@intel.corp-partner.google.com>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Reka Norman <rekanorman@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Henry Sun <henrysun@google.com>
Reviewed-by: Ronak Kanabar <ronak.kanabar@intel.com>
This commit is contained in:
Meera Ravindranath 2022-11-10 11:27:00 +05:30 committed by Subrata Banik
parent 0f864f6ef9
commit f337537a03
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/drivers/wifi/generic/acpi.c
View File

@ -488,7 +488,7 @@ static void emit_sar_acpi_structures(const struct device *dev, struct dsm_profil
/* copy the dsm data to be later used for creating _DSM function */
if (sar_limits.dsm != NULL)
memcpy(dsm, &sar_limits.dsm, sizeof(struct dsm_profile));
memcpy(dsm, sar_limits.dsm, sizeof(struct dsm_profile));
free(sar_limits.sar);
}
@ -571,7 +571,7 @@ static void wifi_ssdt_write_properties(const struct device *dev, const char *sco
dsm_ids[dsm_count].uuid = ACPI_DSM_OEM_WIFI_UUID;
dsm_ids[dsm_count].callbacks = &wifi_dsm_callbacks[0];
dsm_ids[dsm_count].count = ARRAY_SIZE(wifi_dsm_callbacks);
dsm_ids[dsm_count].arg = NULL;
dsm_ids[dsm_count].arg = &dsm;
dsm_count++;
}
}