GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/docker: Fix setting SDK_VERSION 

The `SDK_VERSION` was incorrectly set to itself instead of keeping the
`COREBOOT_IMAGE_TAG` variable, leaving it as an empty string.

Test: Run `make coreboot-sdk` and see `SDK_VERSION` matches the tag.

Fixes: d3a89cdb74 ("util/docker: Replace use of sed with build args")
Change-Id: I4c8be7d0f7c1ac82da397e720d13a7075f22ec4d
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78141
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Martin L Roth <gaumless@gmail.com>
This commit is contained in:
Tim Crawford 2023-09-26 18:30:10 -06:00 committed by Felix Singer
parent fcfdc695a1
commit f339190d07
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
util/docker/Makefile
View File

@ -44,7 +44,7 @@ coreboot-sdk: test-docker
@echo "Building coreboot SDK $(crossgcc_version) from commit $(DOCKER_COMMIT)" @echo "Building coreboot SDK $(crossgcc_version) from commit $(DOCKER_COMMIT)"
$(DOCKER) build \ $(DOCKER) build \
--tag coreboot/coreboot-sdk:$(COREBOOT_IMAGE_TAG) \ --tag coreboot/coreboot-sdk:$(COREBOOT_IMAGE_TAG) \
--build-arg=SDK_VERSION="$(SDK_VERSION)" \ --build-arg=SDK_VERSION="$(COREBOOT_IMAGE_TAG)" \
--build-arg=DOCKER_COMMIT="$(DOCKER_COMMIT)" \ --build-arg=DOCKER_COMMIT="$(DOCKER_COMMIT)" \
--build-arg=CROSSGCC_PARAM="$(COREBOOT_CROSSGCC_PARAM)" \ --build-arg=CROSSGCC_PARAM="$(COREBOOT_CROSSGCC_PARAM)" \
coreboot-sdk coreboot-sdk