From f34fd3cb08b869b1eddb8c3cfa103aea5cee163e Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Mon, 8 May 2023 19:34:18 +0200 Subject: [PATCH] mb/google/corsola: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: I207e25059a9fb9e6a951018e954662931b3f8b93 Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/75018 Reviewed-by: Martin L Roth Tested-by: build bot (Jenkins) --- src/mainboard/google/corsola/Kconfig | 21 +++++++++++++++++++++ src/mainboard/google/corsola/Kconfig.name | 7 ------- 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/src/mainboard/google/corsola/Kconfig b/src/mainboard/google/corsola/Kconfig index e584ee2d79..7bc4831c27 100644 --- a/src/mainboard/google/corsola/Kconfig +++ b/src/mainboard/google/corsola/Kconfig @@ -16,6 +16,27 @@ config BOARD_GOOGLE_STARYU_COMMON def_bool n select BOARD_GOOGLE_CORSOLA_COMMON +config BOARD_GOOGLE_KINGLER + select BOARD_GOOGLE_KINGLER_COMMON + +config BOARD_GOOGLE_STEELIX + select BOARD_GOOGLE_KINGLER_COMMON + +config BOARD_GOOGLE_VOLTORB + select BOARD_GOOGLE_KINGLER_COMMON + +config BOARD_GOOGLE_KRABBY + select BOARD_GOOGLE_KRABBY_COMMON + +config BOARD_GOOGLE_TENTACRUEL + select BOARD_GOOGLE_KRABBY_COMMON + +config BOARD_GOOGLE_MAGIKARP + select BOARD_GOOGLE_KRABBY_COMMON + +config BOARD_GOOGLE_STARMIE + select BOARD_GOOGLE_STARYU_COMMON + if BOARD_GOOGLE_CORSOLA_COMMON config VBOOT diff --git a/src/mainboard/google/corsola/Kconfig.name b/src/mainboard/google/corsola/Kconfig.name index 5f4ee7d8db..2daa86d530 100644 --- a/src/mainboard/google/corsola/Kconfig.name +++ b/src/mainboard/google/corsola/Kconfig.name @@ -2,15 +2,12 @@ comment "Kingler" config BOARD_GOOGLE_KINGLER bool "-> Kingler" - select BOARD_GOOGLE_KINGLER_COMMON config BOARD_GOOGLE_STEELIX bool "-> Steelix" - select BOARD_GOOGLE_KINGLER_COMMON config BOARD_GOOGLE_VOLTORB bool "-> Voltorb" - select BOARD_GOOGLE_KINGLER_COMMON config BOARD_GOOGLE_PONYTA bool "-> Ponyta" @@ -20,18 +17,14 @@ comment "Krabby" config BOARD_GOOGLE_KRABBY bool "-> Krabby" - select BOARD_GOOGLE_KRABBY_COMMON config BOARD_GOOGLE_TENTACRUEL bool "-> Tentacruel" - select BOARD_GOOGLE_KRABBY_COMMON config BOARD_GOOGLE_MAGIKARP bool "-> Magikarp" - select BOARD_GOOGLE_KRABBY_COMMON comment "Staryu" config BOARD_GOOGLE_STARMIE bool "-> Starmie" - select BOARD_GOOGLE_STARYU_COMMON