GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/block/pi/amd_late_init.c: Fix illegal memory access 

Found-by: Coverity (CID 1387031: Memory - illegal accesses
(BUFFER_SIZE_WARNING)). Calling strncpy with a maximum size argument of
19 bytes on destination array "dimm->module_part_number" of size 19 bytes
might leave the destination string unterminated. Fix the size parameter.

BUG=b:76202696
TEST=Build and boot kahlee, using special debug code to see the output
strings, which was later removed.

Change-Id: I18fa5e9c73401575441b6810f1db80d11666368c
Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-on: https://review.coreboot.org/25419
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Richard Spiegel 2018-03-28 13:43:48 -07:00 committed by Martin Roth
parent e07e4f3961
commit f35cc4d60f
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/amd/common/block/pi/amd_late_init.c
View File

@ -59,9 +59,7 @@ static void transfer_memory_info(TYPE17_DMI_INFO *dmi17,
dimm->bank_locator = 0; dimm->bank_locator = 0;
strncpy((char *)dimm->module_part_number, dmi17->PartNumber, strncpy((char *)dimm->module_part_number, dmi17->PartNumber,
sizeof(dimm->module_part_number)); sizeof(dimm->module_part_number) - 1);
dimm->module_part_number[sizeof(dimm->module_part_number) - 1] = 0;
} }
static void print_dimm_info(const struct dimm_info *dimm) static void print_dimm_info(const struct dimm_info *dimm)