GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/amdfwtool: Initalize all variables before use 

Not all of the fields of the amd_cb_config structure were properly
initialized. Rather than initialize each field individually, initialize
the entire structure to 0.

TEST: Boot chausie

Signed-off-by: Fred Reitberger <reitbergerfred@gmail.com>
Change-Id: Ia343f01bce3956d66d01ce485b43963193c9df31
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65533
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
This commit is contained in:
Fred Reitberger 2022-06-29 13:54:57 -04:00 committed by Felix Held
parent 8ee11b3e09
commit f36b0138c4
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
util/amdfwtool/amdfwtool.c
View File

@ -1522,21 +1522,10 @@ int main(int argc, char **argv)
uint8_t efs_spi_speed = 0xff; uint8_t efs_spi_speed = 0xff;
uint8_t efs_spi_micron_flag = 0xff; uint8_t efs_spi_micron_flag = 0xff;
amd_cb_config cb_config; amd_cb_config cb_config = { 0 };
int debug = 0; int debug = 0;
int list_deps = 0; int list_deps = 0;
cb_config.have_whitelist = false;
cb_config.unlock_secure = false;
cb_config.use_secureos = false;
cb_config.load_mp2_fw = false;
cb_config.s0i3 = false;
cb_config.multi_level = false;
cb_config.recovery_ab = false;
cb_config.need_ish = false;
cb_config.recovery_ab_single_copy = false;
cb_config.use_combo = false;
while (1) { while (1) {
int optindex = 0; int optindex = 0;