GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "mb/prodrive/hermes: Add part numbers to SMBIOS" 

This reverts commit d669562663.

Reason for revert: Was submitted out-of-order and with an unresolved
TODO in the commit message.

Change-Id: Id5a8770226afbfcdf63d451157e4586b6cdd5189
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67284
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons 2022-09-20 08:46:43 +00:00 committed by Martin L Roth
parent e36205daf8
commit f37146de32
2 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/mainboard/prodrive/hermes/eeprom.h
View File

@ -86,10 +86,7 @@ struct __packed eeprom_layout {
}; };
char system_serial_number[HERMES_SERIAL_NUMBER_LENGTH]; char system_serial_number[HERMES_SERIAL_NUMBER_LENGTH];
char board_serial_number[HERMES_SERIAL_NUMBER_LENGTH]; char board_serial_number[HERMES_SERIAL_NUMBER_LENGTH];
uint8_t boot_order[0x200]; uint8_t boot_order[0x8c0];
char board_part_number[HERMES_SERIAL_NUMBER_LENGTH];
char product_part_number[HERMES_SERIAL_NUMBER_LENGTH];
uint8_t unused[0x680];
union { union {
uint8_t raw_board_settings[0xf8]; uint8_t raw_board_settings[0xf8];
struct eeprom_board_settings board_settings; struct eeprom_board_settings board_settings;

7
src/mainboard/prodrive/hermes/mainboard.c
View File

@ -174,12 +174,6 @@ static void mainboard_final(struct device *dev)
pmc_soc_set_afterg3_en(on); pmc_soc_set_afterg3_en(on);
} }
static void mainboard_smbios_strings(struct device *dev, struct smbios_type11 *t)
{
t->count = smbios_add_string(t->eos, eeprom_read_serial(board_part_number, "N/A"));
t->count = smbios_add_string(t->eos, eeprom_read_serial(product_part_number, "N/A"));
}
#if CONFIG(HAVE_ACPI_TABLES) #if CONFIG(HAVE_ACPI_TABLES)
static void mainboard_acpi_fill_ssdt(const struct device *dev) static void mainboard_acpi_fill_ssdt(const struct device *dev)
{ {
@ -225,7 +219,6 @@ static void mainboard_enable(struct device *dev)
mb_usb2_fp2_pwr_enable(1); mb_usb2_fp2_pwr_enable(1);
dev->ops->final = mainboard_final; dev->ops->final = mainboard_final;
dev->ops->get_smbios_strings = mainboard_smbios_strings;
#if CONFIG(HAVE_ACPI_TABLES) #if CONFIG(HAVE_ACPI_TABLES)
dev->ops->acpi_fill_ssdt = mainboard_acpi_fill_ssdt; dev->ops->acpi_fill_ssdt = mainboard_acpi_fill_ssdt;