GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/skyrim: Configure GPIO 67 as an unused GPIO 

GPIO 67 is not currently used on skyrim, so set it as no-connect.
Since it's now free for other purposes, make sure that the
SPI-ROM-SHARING functionality is disabled.

BUG=b:268330591
TEST=Examine registers after change

Signed-off-by: Martin Roth <gaumless@gmail.com>
Change-Id: Id083baf41d25920eca09795453a01aac1d00d0f5
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72908
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jon Murphy <jpmurphy@google.com>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Martin Roth 2023-02-08 12:10:15 -07:00 committed by Felix Held
parent ced021a057
commit f411db3561
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/google/skyrim/Kconfig
View File

@ -15,6 +15,7 @@ config BOARD_SPECIFIC_OPTIONS
def_bool y def_bool y
select AMD_SOC_CONSOLE_UART select AMD_SOC_CONSOLE_UART
select BOARD_ROMSIZE_KB_16384 select BOARD_ROMSIZE_KB_16384
select DISABLE_SPI_FLASH_ROM_SHARING
select DRIVERS_GENERIC_GPIO_KEYS select DRIVERS_GENERIC_GPIO_KEYS
select DRIVERS_GENERIC_MAX98357A select DRIVERS_GENERIC_MAX98357A
select DRIVERS_ACPI_THERMAL_ZONE select DRIVERS_ACPI_THERMAL_ZONE

4
src/mainboard/google/skyrim/variants/baseboard/gpio.c
View File

@ -73,8 +73,8 @@ static const struct soc_amd_gpio base_gpio_table[] = {
/* WWAN_RST_L */ /* WWAN_RST_L */
PAD_GPO(GPIO_42, HIGH), PAD_GPO(GPIO_42, HIGH),
/* GPIO_43 - GPIO_66: Not available */ /* GPIO_43 - GPIO_66: Not available */
/* GPIO_67 */ /* GPIO_67 (Unused) */
PAD_GPI(GPIO_67, PULL_NONE), PAD_NC(GPIO_67),
/* ESPI1_DATA2 */ /* ESPI1_DATA2 */
PAD_NF(GPIO_68, SPI1_DAT2, PULL_NONE), PAD_NF(GPIO_68, SPI1_DAT2, PULL_NONE),
/* ESPI1_DATA3 */ /* ESPI1_DATA3 */