GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

inteltool: remove bashism from Makefile 

&> is a bashism to redirect both outward streams (stdout and stderr), but
with other shells this introduces a race condition with the rm command
after it, because the compiler execution is done in the background/
in parallel. Found and tested with dash.

Change-Id: I08516494828c9f7af168f954f2df027372657867
Signed-off-by: Stefan Tauner <stefan.tauner@gmx.at>
Reviewed-on: http://review.coreboot.org/1573
Tested-by: build bot (Jenkins)
Reviewed-by: Bernhard Urban <lewurm@gmail.com>
Reviewed-by: Peter Stuge <peter@stuge.se>
This commit is contained in:
Stefan Tauner 2012-10-13 02:33:35 +02:00 committed by Peter Stuge
parent 36156ffa1e
commit f450b8619e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
util/inteltool/Makefile
View File

@ -59,7 +59,7 @@ pciutils:
printf "struct pci_access *pacc;\n"; \ printf "struct pci_access *pacc;\n"; \
printf "int main(int argc, char **argv)\n"; \ printf "int main(int argc, char **argv)\n"; \
printf "{ pacc = pci_alloc(); return 0; }\n"; ) > .test.c ) printf "{ pacc = pci_alloc(); return 0; }\n"; ) > .test.c )
@$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) &>/dev/null && \ @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) >/dev/null 2>&1 && \
printf "found.\n" || ( printf "not found.\n\n"; \ printf "found.\n" || ( printf "not found.\n\n"; \
printf "Please install pciutils-devel and zlib-devel.\n"; \ printf "Please install pciutils-devel and zlib-devel.\n"; \
printf "See README for more information.\n\n"; \ printf "See README for more information.\n\n"; \