GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AGESA: Use `Flag=AGESA_SUCCESS` instead of `TRUE` in DMI related functions 

Success return value in DMI functions GetDmiInfoMain(..) and GetType4Type7Info(...) of AGESA vendorcode is "Flag = TRUE".

This results in a failure of init late function:

    "agesawrapper_amdinitlate failed: 1"

It happens because TRUE = 1 = AGESA_UNSUPPORTED.

Replacing TRUE with AGESA_SUCCESS (= 0) fixes this problem.

Only family f15tn does not have such bug.

This patch just replaces TRUE with AGESA_SUCCESS, but maybe all DMI functions should be copied from Trinity family?

Tested on Supermicro H8QGI board with 4 AMD Opteron 6234 processors (f15).

Change-Id: I51bf91333c088a825b92d4a44d1ebe4380c8026c
Signed-off-by: Aladyshev Konstantin <aladyshev@nicevt.ru>
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: http://review.coreboot.org/2070
Reviewed-by: Marc Jones <marcj303@gmail.com>
Tested-by: build bot (Jenkins)
This commit is contained in:
Aladyshev Konstantin 2012-12-19 09:31:01 +04:00 committed by Marc Jones
parent c855dce825
commit f50fbe82ad
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/vendorcode/amd/agesa/f10/Proc/CPU/Feature/cpuDmi.c
View File

@ -206,7 +206,7 @@ GetDmiInfoMain (
LOCATE_HEAP_PTR LocateHeapParams; LOCATE_HEAP_PTR LocateHeapParams;
MsrData = 0; MsrData = 0;
Flag = TRUE; Flag = AGESA_SUCCESS;
DmiBufferPtr = *DmiTable; DmiBufferPtr = *DmiTable;
if (DmiBufferPtr == NULL) { if (DmiBufferPtr == NULL) {
// //
@ -387,7 +387,7 @@ GetType4Type7Info (
PROC_FAMILY_TABLE *ProcData; PROC_FAMILY_TABLE *ProcData;
CPU_LOGICAL_ID LogicalID; CPU_LOGICAL_ID LogicalID;
Flag = TRUE; Flag = AGESA_SUCCESS;
DmiBufferPtr = (DMI_INFO *) ApExeParams->RelatedDataBlock; DmiBufferPtr = (DMI_INFO *) ApExeParams->RelatedDataBlock;
GetLogicalIdOfCurrentCore (&LogicalID, &ApExeParams->StdHeader); GetLogicalIdOfCurrentCore (&LogicalID, &ApExeParams->StdHeader);

4
src/vendorcode/amd/agesa/f12/Proc/CPU/Feature/cpuDmi.c
View File

@ -216,7 +216,7 @@ GetDmiInfoMain (
CPU_GET_MEM_INFO CpuGetMemInfo; CPU_GET_MEM_INFO CpuGetMemInfo;
MsrData = 0; MsrData = 0;
Flag = TRUE; Flag = AGESA_SUCCESS;
ProcData = NULL; ProcData = NULL;
MemInfo = NULL; MemInfo = NULL;
DmiBufferPtr = *DmiTable; DmiBufferPtr = *DmiTable;
@ -415,7 +415,7 @@ GetType4Type7Info (
PROC_FAMILY_TABLE *ProcData; PROC_FAMILY_TABLE *ProcData;
CPU_LOGICAL_ID LogicalID; CPU_LOGICAL_ID LogicalID;
Flag = TRUE; Flag = AGESA_SUCCESS;
DmiBufferPtr = (DMI_INFO *) ApExeParams->RelatedDataBlock; DmiBufferPtr = (DMI_INFO *) ApExeParams->RelatedDataBlock;
GetLogicalIdOfCurrentCore (&LogicalID, &ApExeParams->StdHeader); GetLogicalIdOfCurrentCore (&LogicalID, &ApExeParams->StdHeader);

4
src/vendorcode/amd/agesa/f14/Proc/CPU/Feature/cpuDmi.c
View File

@ -220,7 +220,7 @@ GetDmiInfoMain (
CPU_GET_MEM_INFO CpuGetMemInfo; CPU_GET_MEM_INFO CpuGetMemInfo;
MsrData = 0; MsrData = 0;
Flag = TRUE; Flag = AGESA_SUCCESS;
ProcData = NULL; ProcData = NULL;
MemInfo = NULL; MemInfo = NULL;
DmiBufferPtr = *DmiTable; DmiBufferPtr = *DmiTable;
@ -429,7 +429,7 @@ GetType4Type7Info (
PROC_FAMILY_TABLE *ProcData; PROC_FAMILY_TABLE *ProcData;
CPU_LOGICAL_ID LogicalID; CPU_LOGICAL_ID LogicalID;
Flag = TRUE; Flag = AGESA_SUCCESS;
DmiBufferPtr = (DMI_INFO *) ApExeParams->RelatedDataBlock; DmiBufferPtr = (DMI_INFO *) ApExeParams->RelatedDataBlock;
GetLogicalIdOfCurrentCore (&LogicalID, &ApExeParams->StdHeader); GetLogicalIdOfCurrentCore (&LogicalID, &ApExeParams->StdHeader);

4
src/vendorcode/amd/agesa/f15/Proc/CPU/Feature/cpuDmi.c
View File

@ -219,7 +219,7 @@ GetDmiInfoMain (
CPU_GET_MEM_INFO CpuGetMemInfo; CPU_GET_MEM_INFO CpuGetMemInfo;
MsrData = 0; MsrData = 0;
Flag = TRUE; Flag = AGESA_SUCCESS;
ProcData = NULL; ProcData = NULL;
MemInfo = NULL; MemInfo = NULL;
DmiBufferPtr = *DmiTable; DmiBufferPtr = *DmiTable;
@ -439,7 +439,7 @@ GetType4Type7Info (
CPU_LOGICAL_ID LogicalID; CPU_LOGICAL_ID LogicalID;
UINT8 L3Associativity; UINT8 L3Associativity;
Flag = TRUE; Flag = AGESA_SUCCESS;
DmiBufferPtr = (DMI_INFO *) ApExeParams->RelatedDataBlock; DmiBufferPtr = (DMI_INFO *) ApExeParams->RelatedDataBlock;
GetLogicalIdOfCurrentCore (&LogicalID, &ApExeParams->StdHeader); GetLogicalIdOfCurrentCore (&LogicalID, &ApExeParams->StdHeader);