From f516dd8b40a5221780865b40ed51d16cbbc91e56 Mon Sep 17 00:00:00 2001 From: Keith Hui Date: Fri, 25 Aug 2017 12:51:14 -0400 Subject: [PATCH] nb/intel/i440bx/debug.c: Bugfix and cleanup MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix dump_pci_device() broken by commit 65b72ab5 (Drop print_ implementation from non-romcc boards) in 2015 (!) where only one in 16 bytes were being dumped. Also remove the #if made redundant by commit aef8542 (Compile debug.c only if CONFIG_DEBUG_RAM_SETUP) as this whole file is only compiled in that case. Also clean up headers that were included twice. Change-Id: I60e272b29417039feb15540e49d7300f86e5ed21 Signed-off-by: Keith Hui Reviewed-on: https://review.coreboot.org/21203 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Kyösti Mälkki --- src/northbridge/intel/i440bx/debug.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/northbridge/intel/i440bx/debug.c b/src/northbridge/intel/i440bx/debug.c index c69725be52..7d93b1dd2d 100644 --- a/src/northbridge/intel/i440bx/debug.c +++ b/src/northbridge/intel/i440bx/debug.c @@ -2,10 +2,7 @@ #include #include #include "raminit.h" -#include -#include -#if IS_ENABLED(CONFIG_DEBUG_RAM_SETUP) void dump_spd_registers(void) { int i; @@ -44,9 +41,9 @@ void dump_pci_device(unsigned dev) unsigned char val; val = pci_read_config8(dev, i); if ((i & 0x0f) == 0) - printk(BIOS_DEBUG, "%02x: %02x", i, val); + printk(BIOS_DEBUG, "%02x:", i); + printk(BIOS_DEBUG, " %02x", val); if ((i & 0x0f) == 0x0f) printk(BIOS_DEBUG, "\n"); } } -#endif