GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/google/chromeec: Fix oversights in ec_dptf_helpers 

GTSH was 2 instead of 20 (so it's 2 degrees K hysteresis), and TSRD was
accidentally defined to take 0 arguments, instead of 1.

Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Change-Id: I14d28bacf44ac65043060b8579b3fbcec758c56c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43532
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
This commit is contained in:
Tim Wawrzynczak 2020-07-16 14:01:35 -06:00
parent bec6731c76
commit f524188f48
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/ec/google/chromeec/ec_dptf_helpers.c
View File

@ -262,7 +262,7 @@ static void write_dppm_methods(const struct device *ec)
/* TEVT */ /* TEVT */
if (CONFIG(EC_SUPPORTS_DPTF_TEVT)) { if (CONFIG(EC_SUPPORTS_DPTF_TEVT)) {
acpigen_write_method("TEVT", 0); acpigen_write_method("TEVT", 1);
/* Local0 = ToInteger(Arg0) */ /* Local0 = ToInteger(Arg0) */
acpigen_write_to_integer(ARG0_OP, LOCAL0_OP); acpigen_write_to_integer(ARG0_OP, LOCAL0_OP);
@ -308,8 +308,11 @@ static void write_thermal_methods(const struct device *ec, enum dptf_participant
{ {
dptf_write_scope(participant); dptf_write_scope(participant);
/* GTSH - Amount of hysteresis inherent in temperature reading */ /*
acpigen_write_name_integer("GTSH", 2); * GTSH - Amount of hysteresis inherent in temperature reading (2 degrees, in units of
* 1/10th degree K)
*/
acpigen_write_name_integer("GTSH", 20);
/* _TMP - read temperature from EC */ /* _TMP - read temperature from EC */
acpigen_write_method_serialized("_TMP", 0); acpigen_write_method_serialized("_TMP", 0);