GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio/winbond/w83977tf: Only list IR logical device if needed 

Really old versions of W83977TF Super I/O had an IR logical device, but
is no longer the case. It does not exist in the newer W83977EF version,
installed in some Asus P2B family boards, and served by this same code.

Add a config option on the off chance we may see board with it (as if
we would) and don't include this device unless it is set. Saves us from
the need to declare a not-present device off and/or extraneous PNP
device errors about a not-present device.

Change-Id: I761ebc41f1735a03e768339a68ca139167edc095
Signed-off-by: Keith Hui <buurin@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41004
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Keith Hui 2020-05-02 15:24:28 -04:00 committed by Patrick Georgi
parent c844d14ca5
commit f5472a10c6
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/superio/winbond/w83977tf/Kconfig
View File

@ -4,3 +4,9 @@
config SUPERIO_WINBOND_W83977TF config SUPERIO_WINBOND_W83977TF
bool bool
select SUPERIO_WINBOND_COMMON_PRE_RAM select SUPERIO_WINBOND_COMMON_PRE_RAM
config W83977TF_HAVE_SEPARATE_IR_DEVICE
bool
help
Mainboard should select this option if it contains an old
version of W83977TF with a separate IR logical device.

2
src/superio/winbond/w83977tf/superio.c
View File

@ -37,7 +37,9 @@ static struct pnp_info pnp_dev_info[] = {
{ NULL, W83977TF_SP2, PNP_IO0 | PNP_IRQ0, 0x07f8, }, { NULL, W83977TF_SP2, PNP_IO0 | PNP_IRQ0, 0x07f8, },
{ NULL, W83977TF_KBC, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_IRQ1, { NULL, W83977TF_KBC, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_IRQ1,
0x07ff, 0x07ff, }, 0x07ff, 0x07ff, },
#if CONFIG(W83977TF_HAVE_SEPARATE_IR_DEVICE)
{ NULL, W83977TF_CIR, PNP_IO0 | PNP_IRQ0, 0x07f8, }, { NULL, W83977TF_CIR, PNP_IO0 | PNP_IRQ0, 0x07f8, },
#endif
{ NULL, W83977TF_GAME_MIDI_GPIO1, PNP_IO0 | PNP_IO1 | PNP_IRQ0, { NULL, W83977TF_GAME_MIDI_GPIO1, PNP_IO0 | PNP_IO1 | PNP_IRQ0,
0x07ff, 0x07fe, }, 0x07ff, 0x07fe, },
{ NULL, W83977TF_ACPI, PNP_IRQ0, }, { NULL, W83977TF_ACPI, PNP_IRQ0, },