From f586df4e5cb3f4ab39ea20478d1e74192b9c7658 Mon Sep 17 00:00:00 2001 From: Sheng-Liang Pan Date: Wed, 9 Jun 2021 14:57:33 +0800 Subject: [PATCH] mb/google/volteer/var/volet: remove USB4_GEN3 configuration for volet. volet don't support usb4, remove it to prevent USBC(P0) issue. BUG=b:189740531 TEST=build and verify USB(P0) disaply out normal Signed-off-by: Sheng-Liang Pan Change-Id: Ia78c7cee76ec2e3a5334ad8805a0d45616aade93 Reviewed-on: https://review.coreboot.org/c/coreboot/+/55344 Reviewed-by: YH Lin Reviewed-by: Zhuohao Lee Reviewed-by: Tim Wawrzynczak Reviewed-by: Nick Vaccaro Tested-by: build bot (Jenkins) --- .../volteer/variants/volet/overridetree.cb | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/src/mainboard/google/volteer/variants/volet/overridetree.cb b/src/mainboard/google/volteer/variants/volet/overridetree.cb index bc8cb499e4..c2b6c7450f 100644 --- a/src/mainboard/google/volteer/variants/volet/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volet/overridetree.cb @@ -124,11 +124,6 @@ chip soc/intel/tigerlake device generic 0 on end end end - # This variant has USB4/PCIe on both ports so RP0 must be enabled - # in order for hotplug resources to be assigned to Type-C Port C0. - device ref tbt_pcie_rp0 on - probe DB_USB USB4_GEN3 - end device ref pmc hidden # The pmc_mux chip driver is a placeholder for the # PMC.MUX device in the ACPI hierarchy. @@ -171,12 +166,10 @@ chip soc/intel/tigerlake chip drivers/usb/acpi device ref xhci_root_hub on chip drivers/usb/acpi - register "desc" = ""USB2 Type-A Port A1 (DB)"" + register "desc" = ""USB2 Type-A Port A1 (MLB)"" register "type" = "UPC_TYPE_A" register "group" = "ACPI_PLD_GROUP(1, 1)" - device ref usb2_port2 on - probe DB_USB USB4_GEN3 - end + device ref usb2_port2 on end end chip drivers/usb/acpi register "desc" = ""USB2 Type-C Port C1 (MLB)"" @@ -202,12 +195,10 @@ chip soc/intel/tigerlake device ref usb2_port10 on end end chip drivers/usb/acpi - register "desc" = ""USB3 Type-A Port A1 (DB)"" + register "desc" = ""USB3 Type-A Port A1 (MLB)"" register "type" = "UPC_TYPE_USB3_A" register "group" = "ACPI_PLD_GROUP(1, 2)" - device ref usb3_port2 on - probe DB_USB USB4_GEN3 - end + device ref usb3_port2 on end end end end