From f5afc1a5a2a04c6961b0f86d2b47c801c222f065 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Thu, 8 Sep 2022 10:53:01 -0700 Subject: [PATCH] soc/intel/meteorlake: Drop redundant `MCHBAR` programming in romstage This patch drops redundant MCHBAR programming in romstage as bootblock already done with MCHBAR setting up. TEST=Able to boot Google/Rex to ChromeOS and MCHBAR is set to correct value as per iomap.h Signed-off-by: Subrata Banik Change-Id: Ic2c05f47ab22dc7fe087782a1ce9b7b692ea157e Reviewed-on: https://review.coreboot.org/c/coreboot/+/67455 Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal --- src/soc/intel/meteorlake/romstage/systemagent.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/soc/intel/meteorlake/romstage/systemagent.c b/src/soc/intel/meteorlake/romstage/systemagent.c index 6e9b9fa486..ba9b72cd08 100644 --- a/src/soc/intel/meteorlake/romstage/systemagent.c +++ b/src/soc/intel/meteorlake/romstage/systemagent.c @@ -8,7 +8,6 @@ void systemagent_early_init(void) { static const struct sa_mmio_descriptor soc_fixed_pci_resources[] = { - { MCHBAR, MCH_BASE_ADDRESS, MCH_BASE_SIZE, "MCHBAR" }, { DMIBAR, DMI_BASE_ADDRESS, DMI_BASE_SIZE, "DMIBAR" }, { EPBAR, EP_BASE_ADDRESS, EP_BASE_SIZE, "EPBAR" }, };