From f5e8fe5d95844cafc100b409cea1f15e62a51e9c Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Wed, 25 Oct 2017 09:52:53 -0700 Subject: [PATCH] soc/intel/apollolake: Fix broken GNVS offset for chromeos Change 03a235(soc/intel/apollolake: Add GNVS variables and include SGX ASL) added new GNVS variables but did not adjust the unused array size and thus broke chromeos offset. This change fixes the above issue by reducing the size of unused array. BUG=b:68254376 TEST=Verified that chromeos offset is correct. crossystem is able to read all variables. Change-Id: I279bfc4c702e46b88c1c7a067a24326ff8fed368 Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/22177 Reviewed-by: Aaron Durbin Tested-by: build bot (Jenkins) --- src/soc/intel/apollolake/include/soc/nvs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/intel/apollolake/include/soc/nvs.h b/src/soc/intel/apollolake/include/soc/nvs.h index dd0746b1dd..2c9a4b5a54 100644 --- a/src/soc/intel/apollolake/include/soc/nvs.h +++ b/src/soc/intel/apollolake/include/soc/nvs.h @@ -47,7 +47,7 @@ typedef struct global_nvs_t { uint8_t ecps; /* 0x2C - SGX Enabled status */ uint64_t emna; /* 0x2D - 0x34 EPC base address */ uint64_t elng; /* 0x35 - 0x3C EPC Length */ - uint8_t unused[212]; + uint8_t unused[195]; /* ChromeOS specific (0x100 - 0xfff) */ chromeos_acpi_t chromeos;