From f5f552afcd471ba7ab9dbd77789f2076af176865 Mon Sep 17 00:00:00 2001 From: Kevin Cody-Little Date: Thu, 10 May 2018 21:33:03 -0400 Subject: [PATCH] superio/ite/it8623e: initialize the PWM fan controller MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Copies the common/env_ctrl support code from the it8728f driver. Tested on an ASUS AM1I-A using Linux 4.16.7-gentoo as payload, and booting userspace without a kexec call. Prior to this change, an error was given during boot: it87 it87.656: Detected broken BIOS defaults, disabling PWM interface After this change, the message is gone, and PWM fan control works through the /sys/class/hwmon interface. Change-Id: Id97c4ec19562e7c78308c5afe6ff7c938922c9e7 Signed-off-by: Kevin Cody-Little Reviewed-on: https://review.coreboot.org/26224 Reviewed-by: Felix Held Reviewed-by: Nico Huber Reviewed-by: Kyösti Mälkki Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- src/superio/ite/it8623e/Kconfig | 5 +++++ src/superio/ite/it8623e/chip.h | 26 ++++++++++++++++++++++++++ src/superio/ite/it8623e/superio.c | 8 ++++++++ 3 files changed, 39 insertions(+) create mode 100644 src/superio/ite/it8623e/chip.h diff --git a/src/superio/ite/it8623e/Kconfig b/src/superio/ite/it8623e/Kconfig index 1b4fe4a8bd..274959e2be 100644 --- a/src/superio/ite/it8623e/Kconfig +++ b/src/superio/ite/it8623e/Kconfig @@ -4,6 +4,7 @@ ## Copyright (C) 2009 Ronald G. Minnich ## Copyright (C) 2014 Edward O'Callaghan ## Copyright (C) 2017 Gergely Kiss +## Copyright (C) 2018 Kevin Cody-Little ## ## This program is free software; you can redistribute it and/or modify ## it under the terms of the GNU General Public License as published by @@ -18,3 +19,7 @@ config SUPERIO_ITE_IT8623E bool select SUPERIO_ITE_COMMON_ROMSTAGE + select SUPERIO_ITE_ENV_CTRL + select SUPERIO_ITE_ENV_CTRL_PWM_FREQ2 + select SUPERIO_ITE_ENV_CTRL_FAN16_CONFIG + select SUPERIO_ITE_ENV_CTRL_8BIT_PWM diff --git a/src/superio/ite/it8623e/chip.h b/src/superio/ite/it8623e/chip.h new file mode 100644 index 0000000000..c92b4512f7 --- /dev/null +++ b/src/superio/ite/it8623e/chip.h @@ -0,0 +1,26 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2014 Edward O'Callaghan + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef SUPERIO_ITE_IT8623E_CHIP_H +#define SUPERIO_ITE_IT8623E_CHIP_H + +#include + +struct superio_ite_it8623e_config { + struct ite_ec_config ec; +}; + +#endif /* SUPERIO_ITE_IT8623E_CHIP_H */ diff --git a/src/superio/ite/it8623e/superio.c b/src/superio/ite/it8623e/superio.c index e1ae5036a9..a9cd4e55ae 100644 --- a/src/superio/ite/it8623e/superio.c +++ b/src/superio/ite/it8623e/superio.c @@ -22,17 +22,25 @@ #include #include #include +#include +#include "chip.h" #include "it8623e.h" static void it8623e_init(struct device *dev) { + const struct superio_ite_it8623e_config *conf = dev->chip_info; + const struct resource *res; if (!dev->enabled) return; switch (dev->path.pnp.device) { case IT8623E_EC: + res = find_resource(dev, PNP_IDX_IO0); + if (!conf || !res) + break; + ite_ec_init(res->base, &conf->ec); break; case IT8623E_KBCK: pc_keyboard_init(NO_AUX_DEVICE);