From f6056113e5a9f93174eb4296d1230d10ebb2bede Mon Sep 17 00:00:00 2001 From: Mario Scheithauer Date: Tue, 22 Feb 2022 09:46:33 +0100 Subject: [PATCH] console: Fix LOG_FAST macro In the LOG_FAST macro, the comparison was incorrectly made with 'level' value. Correct is the comparison with 'speed'. With the wrong comparison you cannot set a lower level for console log, the highest level is always output. TEST: - Boot mc_ehl2 with console log level 5 and check output Change-Id: Ib5b4537ae2cbf01c51c3568d312b5242c4bee7bb Signed-off-by: Mario Scheithauer Reviewed-on: https://review.coreboot.org/c/coreboot/+/62261 Tested-by: build bot (Jenkins) Reviewed-by: Julius Werner Reviewed-by: Paul Menzel Reviewed-by: Patrick Georgi Reviewed-by: Arthur Heymans --- src/console/printk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/console/printk.c b/src/console/printk.c index 341c255538..eb35c53f22 100644 --- a/src/console/printk.c +++ b/src/console/printk.c @@ -67,7 +67,7 @@ union log_state { }; }; -#define LOG_FAST(state) (HAS_ONLY_FAST_CONSOLES || ((state).level == CONSOLE_LOG_FAST)) +#define LOG_FAST(state) (HAS_ONLY_FAST_CONSOLES || ((state).speed == CONSOLE_LOG_FAST)) static void wrap_interactive_printf(const char *fmt, ...) {