From f63dd17bb1b7bc19e87008a7122db7d150d35c69 Mon Sep 17 00:00:00 2001 From: Raul E Rangel Date: Tue, 8 Mar 2022 13:40:01 -0700 Subject: [PATCH] mb/google/guybrush: Enable DEBUG_SMI for non-serial firmware In order to copy the PSP verstage logs into x86 cbmem, we need to enable DEBUG_SMI. This will include the CBMEM console code in SMM. I only enable DEBUG_SMI when UART is disabled because SMM doesn't currently save/restore the UART registers. This will result in clearing the interrupt enable bits and makes it so you can no longer use the TTY. BUG=b:221231786, b:217968734 BRANCH=guybrush TEST=Build serial and non serial firmware and verify DEBUG_SMI is set correctly. Signed-off-by: Raul E Rangel Change-Id: I85a7933e8eb49ff920d00e43a494aaeab555ef3b Reviewed-on: https://review.coreboot.org/c/coreboot/+/62670 Tested-by: build bot (Jenkins) Reviewed-by: Karthik Ramasubramanian --- src/mainboard/google/guybrush/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mainboard/google/guybrush/Kconfig b/src/mainboard/google/guybrush/Kconfig index ecec68849a..b2cba6ecab 100644 --- a/src/mainboard/google/guybrush/Kconfig +++ b/src/mainboard/google/guybrush/Kconfig @@ -13,6 +13,7 @@ config BOARD_SPECIFIC_OPTIONS select AMD_SOC_CONSOLE_UART select BOARD_ROMSIZE_KB_16384 select CONSOLE_CBMEM_DUMP_TO_UART if !CONSOLE_SERIAL + select DEBUG_SMI if !CONSOLE_SERIAL # TODO(b/217968734): Always enable select DISABLE_KEYBOARD_RESET_PIN select DISABLE_SPI_FLASH_ROM_SHARING select DRIVERS_ACPI_THERMAL_ZONE