From f658b3588904737b1641bd1664dd17e9a6805237 Mon Sep 17 00:00:00 2001 From: Jon Murphy Date: Fri, 20 May 2022 14:19:36 -0600 Subject: [PATCH] mb/google/guybrush: Remove TODO's and update text Remove TODO's for dummy DXIO descriptors, update comment to reflect what they are. These devices are needed for the platform to function properly. Also remove the TODO for DDI descriptors as they are functioning correctly. BUG=b:232952508 TEST=Builds Signed-off-by: Jon Murphy Change-Id: I1535c08cac3f0bcb30061aba2aa593eb22109387 Reviewed-on: https://review.coreboot.org/c/coreboot/+/64557 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel --- src/mainboard/google/guybrush/port_descriptors.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mainboard/google/guybrush/port_descriptors.c b/src/mainboard/google/guybrush/port_descriptors.c index 040298b92d..b2a7e64469 100644 --- a/src/mainboard/google/guybrush/port_descriptors.c +++ b/src/mainboard/google/guybrush/port_descriptors.c @@ -70,7 +70,7 @@ static fsp_dxio_descriptor guybrush_czn_dxio_descriptors[] = { .clk_req = CLK_REQ3, .port_params = {PP_PSPP_AC, 0x133, PP_PSPP_DC, 0x122} }, - { /* TODO: remove this temporary workaround */ + { /* Dummy Device */ .engine_type = PCIE_ENGINE, .port_present = true, .start_logical_lane = 8, @@ -81,7 +81,7 @@ static fsp_dxio_descriptor guybrush_czn_dxio_descriptors[] = { .clk_req = CLK_REQ5, .port_params = {PP_PSPP_AC, 0x133, PP_PSPP_DC, 0x122} }, - { /* TODO: remove this temporary workaround */ + { /* Dummy Device */ .engine_type = PCIE_ENGINE, .port_present = true, .start_logical_lane = 16, @@ -94,7 +94,6 @@ static fsp_dxio_descriptor guybrush_czn_dxio_descriptors[] = { } }; -/* TODO: verify the DDI table, since this is mostly an educated guess right now */ static fsp_ddi_descriptor guybrush_czn_ddi_descriptors[] = { { /* DDI0 - eDP */ .connector_type = DDI_EDP,