From f696d797dcc162e8ed27a6720d1253f00a5f0128 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Wed, 26 May 2021 14:19:09 +0200 Subject: [PATCH] ec/kontron/kempld: Guard macro parameters Add parentheses around macro parameters to avoid operation order issues. Change-Id: I2d4552abaeda5702619cc53e9dfae1f17b048e67 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/54952 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- src/ec/kontron/kempld/kempld_internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ec/kontron/kempld/kempld_internal.h b/src/ec/kontron/kempld/kempld_internal.h index 014778c1cc..993fe8edd1 100644 --- a/src/ec/kontron/kempld/kempld_internal.h +++ b/src/ec/kontron/kempld/kempld_internal.h @@ -12,8 +12,8 @@ /* indexed registers */ #define KEMPLD_SPEC 0x06 -#define KEMPLD_SPEC_GET_MINOR(x) (x & 0x0f) -#define KEMPLD_SPEC_GET_MAJOR(x) (x >> 4 & 0x0f) +#define KEMPLD_SPEC_GET_MINOR(x) ((x) & 0x0f) +#define KEMPLD_SPEC_GET_MAJOR(x) ((x) >> 4 & 0x0f) #define KEMPLD_CFG 0x37 #define KEMPLD_CFG_GPIO_I2C_MUX (1 << 0)