GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/googlz/zork: Drop unnecessary PULL_UPs in variant overrides 

This change drops the pulls configured on override GPIOs as they
already have external pull-ups. Also, pads which are unused are
configured as PAD_NC.

BUG=b:154351731

Change-Id: I8da5d51af25bbe2694c21ecb0868c9cc387243cb
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43562
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Furquan Shaikh 2020-07-17 15:30:47 -07:00
parent b4b4e32e4c
commit f6b2e6f836
5 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/zork/variants/berknip/gpio.c
View File

@ -11,9 +11,9 @@ static const struct soc_amd_gpio berknip_bid1_gpio_set_stage_ram[] = {
/* DMIC_SEL */ /* DMIC_SEL */
PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic
/* USB_OC4_L - USB_A1 */ /* USB_OC4_L - USB_A1 */
PAD_NF(GPIO_14, USB_OC4_L, PULL_UP), PAD_NF(GPIO_14, USB_OC4_L, PULL_NONE),
/* USB_OC2_L - USB A0 */ /* USB_OC2_L - USB A0 */
PAD_NF(GPIO_18, USB_OC2_L, PULL_UP), PAD_NF(GPIO_18, USB_OC2_L, PULL_NONE),
/* EN_PWR_TOUCHPAD_PS2 */ /* EN_PWR_TOUCHPAD_PS2 */
PAD_GPO(GPIO_67, HIGH), PAD_GPO(GPIO_67, HIGH),
/* MST_GPIO_2 (Fw Update HDMI hub) */ /* MST_GPIO_2 (Fw Update HDMI hub) */

4
src/mainboard/google/zork/variants/dalboz/gpio.c
View File

@ -12,11 +12,11 @@ static const struct soc_amd_gpio bid_1_gpio_set_stage_ram[] = {
/* DMIC_SEL */ /* DMIC_SEL */
PAD_GPO(GPIO_6, LOW), // Select Camera 1 DMIC PAD_GPO(GPIO_6, LOW), // Select Camera 1 DMIC
/* USB_OC2_L - USB A0 & A1 */ /* USB_OC2_L - USB A0 & A1 */
PAD_NF(GPIO_18, USB_OC2_L, PULL_UP), PAD_NF(GPIO_18, USB_OC2_L, PULL_NONE),
/* EN_PWR_TOUCHPAD_PS2 */ /* EN_PWR_TOUCHPAD_PS2 */
PAD_GPO(GPIO_67, HIGH), PAD_GPO(GPIO_67, HIGH),
/* Unused */ /* Unused */
PAD_GPI(GPIO_143, PULL_DOWN), PAD_NC(GPIO_143),
}; };
static const struct soc_amd_gpio bid_2_gpio_set_stage_ram[] = { static const struct soc_amd_gpio bid_2_gpio_set_stage_ram[] = {

14
src/mainboard/google/zork/variants/ezkinil/gpio.c
View File

@ -11,9 +11,9 @@ static const struct soc_amd_gpio ezkinil_bid1_gpio_set_stage_ram[] = {
/* DMIC_SEL */ /* DMIC_SEL */
PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic
/* USB_OC4_L - USB_A1 */ /* USB_OC4_L - USB_A1 */
PAD_NF(GPIO_14, USB_OC4_L, PULL_UP), PAD_NF(GPIO_14, USB_OC4_L, PULL_NONE),
/* USB_OC2_L - USB A0 */ /* USB_OC2_L - USB A0 */
PAD_NF(GPIO_18, USB_OC2_L, PULL_UP), PAD_NF(GPIO_18, USB_OC2_L, PULL_NONE),
/* EN_PWR_TOUCHPAD_PS2 */ /* EN_PWR_TOUCHPAD_PS2 */
PAD_GPO(GPIO_67, HIGH), PAD_GPO(GPIO_67, HIGH),
/* MST_GPIO_2 (Fw Update HDMI hub) */ /* MST_GPIO_2 (Fw Update HDMI hub) */
@ -24,22 +24,22 @@ static const struct soc_amd_gpio ezkinil_bid1_gpio_set_stage_ram[] = {
static const struct soc_amd_gpio ezkinil_bid2_gpio_set_stage_ram[] = { static const struct soc_amd_gpio ezkinil_bid2_gpio_set_stage_ram[] = {
/* FPMCU_RST_L Change NC */ /* FPMCU_RST_L Change NC */
PAD_GPI(GPIO_11, PULL_UP), PAD_NC(GPIO_11),
/* DMIC_SEL */ /* DMIC_SEL */
PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic
/* EN_PWR_TOUCHPAD_PS2 */ /* EN_PWR_TOUCHPAD_PS2 */
PAD_GPO(GPIO_67, HIGH), PAD_GPO(GPIO_67, HIGH),
/* FPMCU_BOOT0 Change NC */ /* FPMCU_BOOT0 Change NC */
PAD_GPI(GPIO_69, PULL_UP), PAD_NC(GPIO_69),
/* MST_GPIO_2 (Fw Update HDMI hub) Change NC */ /* MST_GPIO_2 (Fw Update HDMI hub) Change NC */
PAD_GPI(GPIO_86, PULL_UP), PAD_NC(GPIO_86),
}; };
static const struct soc_amd_gpio ezkinil_bid3_gpio_set_stage_ram[] = { static const struct soc_amd_gpio ezkinil_bid3_gpio_set_stage_ram[] = {
/* FPMCU_RST_L Change NC */ /* FPMCU_RST_L Change NC */
PAD_GPI(GPIO_11, PULL_UP), PAD_NC(GPIO_11),
/* FPMCU_BOOT0 Change NC */ /* FPMCU_BOOT0 Change NC */
PAD_GPI(GPIO_69, PULL_UP), PAD_NC(GPIO_69),
}; };
const struct soc_amd_gpio *variant_override_gpio_table(size_t *size) const struct soc_amd_gpio *variant_override_gpio_table(size_t *size)

8
src/mainboard/google/zork/variants/morphius/gpio.c
View File

@ -11,9 +11,9 @@ static const struct soc_amd_gpio morphius_bid1_gpio_set_stage_ram[] = {
/* DMIC_SEL */ /* DMIC_SEL */
PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic
/* USB_OC4_L - USB_A1 */ /* USB_OC4_L - USB_A1 */
PAD_NF(GPIO_14, USB_OC4_L, PULL_UP), PAD_NF(GPIO_14, USB_OC4_L, PULL_NONE),
/* USB_OC2_L - USB A0 */ /* USB_OC2_L - USB A0 */
PAD_NF(GPIO_18, USB_OC2_L, PULL_UP), PAD_NF(GPIO_18, USB_OC2_L, PULL_NONE),
/* EN_PWR_TOUCHPAD_PS2 */ /* EN_PWR_TOUCHPAD_PS2 */
PAD_GPO(GPIO_67, HIGH), PAD_GPO(GPIO_67, HIGH),
/* DMIC_AD_EN */ /* DMIC_AD_EN */
@ -28,9 +28,9 @@ static const struct soc_amd_gpio morphius_bid2_gpio_set_stage_ram[] = {
/* DMIC_SEL */ /* DMIC_SEL */
PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic
/* USB_OC4_L - USB_A1 */ /* USB_OC4_L - USB_A1 */
PAD_NF(GPIO_14, USB_OC4_L, PULL_UP), PAD_NF(GPIO_14, USB_OC4_L, PULL_NONE),
/* USB_OC2_L - USB A0 */ /* USB_OC2_L - USB A0 */
PAD_NF(GPIO_18, USB_OC2_L, PULL_UP), PAD_NF(GPIO_18, USB_OC2_L, PULL_NONE),
/* EN_PWR_TOUCHPAD_PS2 */ /* EN_PWR_TOUCHPAD_PS2 */
PAD_GPO(GPIO_67, HIGH), PAD_GPO(GPIO_67, HIGH),
/* MST_GPIO_2 (Fw Update HDMI hub) */ /* MST_GPIO_2 (Fw Update HDMI hub) */

8
src/mainboard/google/zork/variants/trembyle/gpio.c
View File

@ -11,9 +11,9 @@ static const struct soc_amd_gpio trembyle_bid1_bid2_gpio_set_stage_ram[] = {
/* DMIC_SEL */ /* DMIC_SEL */
PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic
/* USB_OC4_L - USB_A1 */ /* USB_OC4_L - USB_A1 */
PAD_NF(GPIO_14, USB_OC4_L, PULL_UP), PAD_NF(GPIO_14, USB_OC4_L, PULL_NONE),
/* USB_OC2_L - USB A0 */ /* USB_OC2_L - USB A0 */
PAD_NF(GPIO_18, USB_OC2_L, PULL_UP), PAD_NF(GPIO_18, USB_OC2_L, PULL_NONE),
/* EN_PWR_TOUCHPAD_PS2 */ /* EN_PWR_TOUCHPAD_PS2 */
PAD_GPO(GPIO_67, HIGH), PAD_GPO(GPIO_67, HIGH),
/* DMIC_AD_EN */ /* DMIC_AD_EN */
@ -28,9 +28,9 @@ static const struct soc_amd_gpio trembyle_bid3_gpio_set_stage_ram[] = {
/* DMIC_SEL */ /* DMIC_SEL */
PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic
/* USB_OC4_L - USB_A1 */ /* USB_OC4_L - USB_A1 */
PAD_NF(GPIO_14, USB_OC4_L, PULL_UP), PAD_NF(GPIO_14, USB_OC4_L, PULL_NONE),
/* USB_OC2_L - USB A0 */ /* USB_OC2_L - USB A0 */
PAD_NF(GPIO_18, USB_OC2_L, PULL_UP), PAD_NF(GPIO_18, USB_OC2_L, PULL_NONE),
/* EN_PWR_TOUCHPAD_PS2 */ /* EN_PWR_TOUCHPAD_PS2 */
PAD_GPO(GPIO_67, HIGH), PAD_GPO(GPIO_67, HIGH),
/* MST_GPIO_2 (Fw Update HDMI hub) */ /* MST_GPIO_2 (Fw Update HDMI hub) */