GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/sandybridge/raminit: Get rid of fallback attempts 

Locking the PLL again once it's locked doesn't work.
The MRC doesn't do this, for some reason.
Remove fallback attempts of lowering DDR frequency.

Change-Id: Iccb54fa7d7357a22182dd26bd5b49c4073c04dc9
Signed-off-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-on: https://review.coreboot.org/17399
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Patrick Rudolph 2016-11-12 11:39:57 +01:00
parent bec669685c
commit f704754847
1 changed files with 1 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/northbridge/intel/sandybridge/raminit.c
View File

@ -834,11 +834,8 @@ static void dram_freq(ramctr_timing * ctrl)
*/ */
reg1 = MCHBAR32(0x5e04); reg1 = MCHBAR32(0x5e04);
val2 = (u8) reg1; val2 = (u8) reg1;
if (val2 == FRQ) { if (val2)
printk(BIOS_DEBUG, "MCU frequency is set at : %d MHz\n",
(1000 << 8) / ctrl->tCK);
return; return;
}
/* Step 2 - Select frequency in the MCU */ /* Step 2 - Select frequency in the MCU */
reg1 = FRQ; reg1 = FRQ;
@ -4275,22 +4272,6 @@ void init_dram_ddr3(spd_raw_data *spds, int mobile, int min_tck,
err = try_init_dram_ddr3(&ctrl, fast_boot, s3resume, me_uma_size); err = try_init_dram_ddr3(&ctrl, fast_boot, s3resume, me_uma_size);
} }
if (err && (ctrl.tCK < TCK_400MHZ)) {
/* fallback: lower clock frequency */
printk(BIOS_ERR, "RAM training failed, trying fallback.\n");
printram("Decreasing clock frequency.\n");
ctrl.tCK++;
err = try_init_dram_ddr3(&ctrl, fast_boot, s3resume, me_uma_size);
}
if (err && (ctrl.tCK < TCK_400MHZ)) {
/* fallback: lower clock frequency */
printk(BIOS_ERR, "RAM training failed, trying fallback.\n");
printram("Decreasing clock frequency.\n");
ctrl.tCK++;
err = try_init_dram_ddr3(&ctrl, fast_boot, s3resume, me_uma_size);
}
if (err) { if (err) {
/* fallback: disable failing channel */ /* fallback: disable failing channel */
printk(BIOS_ERR, "RAM training failed, trying fallback.\n"); printk(BIOS_ERR, "RAM training failed, trying fallback.\n");