From f708b058e8f2c1a5c2a6fb16238b19f73735af46 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Fri, 24 Jun 2022 22:07:42 +0200 Subject: [PATCH] allocator_v4: Drop spurious rule from comment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The comment said special care needs to be taken if a resource cannot be allocated. However, the opposite seems true: There is nothing to be done, we simply leave the resource w/o the IORESOURCE_ASSIGNED flag. There's also no code to be found that would currently do some- thing special. allocate_child_resources() directly continues with the next resource after printing an error. Change-Id: I21acbc891ea4dfb62decf9abe0ace91016486116 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/coreboot/+/65412 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki Reviewed-by: Angel Pons --- src/device/resource_allocator_v4.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/device/resource_allocator_v4.c b/src/device/resource_allocator_v4.c index 6f8159e1b1..88f21f8a9f 100644 --- a/src/device/resource_allocator_v4.c +++ b/src/device/resource_allocator_v4.c @@ -648,9 +648,6 @@ static void allocate_domain_resources(const struct device *domain) * * Some rules that are followed by the resource allocator: * - Allocate resource locations for every device as long as the requirements can be satisfied. - * - If a resource cannot be allocated any address space, then that resource needs to be - * properly updated to ensure that it does not incorrectly overlap some address space reserved - * for a different purpose. * - Don't overlap with resources in fixed locations. * - Don't overlap and follow the rules of bridges -- downstream devices of bridges should use * parts of the address space allocated to the bridge.