From f730e44baaf061e2ab8ea4e21b5b0d60bc681dc3 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Wed, 18 Nov 2015 16:13:12 -0700 Subject: [PATCH] google/veyron_danger & veyron_emile: Fix Kconfig warnings These platforms needed to be adjusted to fix various Kconfig warnings. Both platforms needed MAINBOARD_HAS_NATIVE_VGA_INIT because they're setting MAINBOARD_DO_NATIVE_VGA_INIT. veyron_emile needed a few symbols that depend on CHROMEOS to be moved into a new config CHROMEOS section. This matches the other CHROMEOS platforms. veyron_danger needed to select MAINBOARD_HAS_CHROMEOS before the CHROMEOS symbol was set. Change-Id: I8c7f594ba572a02513a68095c16314006fb4e379 Signed-off-by: Martin Roth Reviewed-on: http://review.coreboot.org/12462 Reviewed-by: Stefan Reinauer Tested-by: build bot (Jenkins) --- src/mainboard/google/veyron_danger/Kconfig | 2 ++ src/mainboard/google/veyron_emile/Kconfig | 7 +++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/mainboard/google/veyron_danger/Kconfig b/src/mainboard/google/veyron_danger/Kconfig index 326d94024d..ab549f6d77 100644 --- a/src/mainboard/google/veyron_danger/Kconfig +++ b/src/mainboard/google/veyron_danger/Kconfig @@ -29,6 +29,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy select SPI_FLASH select SPI_FLASH_GIGADEVICE select SPI_FLASH_WINBOND + select MAINBOARD_HAS_NATIVE_VGA_INIT + select MAINBOARD_HAS_CHROMEOS config CHROMEOS select CHROMEOS_VBNV_FLASH diff --git a/src/mainboard/google/veyron_emile/Kconfig b/src/mainboard/google/veyron_emile/Kconfig index d6ab870de1..af606e0d02 100644 --- a/src/mainboard/google/veyron_emile/Kconfig +++ b/src/mainboard/google/veyron_emile/Kconfig @@ -27,14 +27,17 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_HARD_RESET select MAINBOARD_DO_NATIVE_VGA_INIT select MAINBOARD_HAS_CHROMEOS - select PHYSICAL_REC_SWITCH select RAM_CODE_SUPPORT select SOC_ROCKCHIP_RK3288 select SPI_FLASH select SPI_FLASH_GIGADEVICE select SPI_FLASH_WINBOND - select VIRTUAL_DEV_SWITCH + select MAINBOARD_HAS_NATIVE_VGA_INIT + +config CHROMEOS select CHROMEOS_VBNV_FLASH + select PHYSICAL_REC_SWITCH + select VIRTUAL_DEV_SWITCH config MAINBOARD_DIR string