pcengines/apu2: Switch away from BINARYPI_LEGACY_WRAPPER
Adopting the mainboard code to use hooks from state_machine.h. No post codes are changed, except for those which were explicitly sent in mainboard/romstage.c. Boot time is reduced by more than 7%, from 5.029s to 4.657s (coreboot timestamps, measured for loglevel 7). POSTCAR_STAGE is required since coreboot 4.11 release. TEST=boot PC Engines apu2 and launch Debian Linux with 4.14.50 kernel Change-Id: Iff3dbe68ac17eb2947ff40b9769c6650255656cf Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com> Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/32363 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Krystian Hebel
Kyösti Mälkki
parent
6a23352515
commit
f77f2c79c2
|
|
@ -17,6 +17,7 @@
|
|||
#include <console/console.h>
|
||||
#include <spd_bin.h>
|
||||
#include <northbridge/amd/agesa/BiosCallOuts.h>
|
||||
#include <northbridge/amd/agesa/state_machine.h>
|
||||
#include <FchPlatform.h>
|
||||
#include <stdlib.h>
|
||||
|
||||
|
|
@ -24,7 +25,6 @@
|
|||
#include "imc.h"
|
||||
#include "hudson.h"
|
||||
|
||||
static AGESA_STATUS Fch_Oem_config(UINT32 Func, UINTN FchData, VOID *ConfigPtr);
|
||||
static AGESA_STATUS board_ReadSpd_from_cbfs(UINT32 Func, UINTN Data, VOID *ConfigPtr);
|
||||
|
||||
const BIOS_CALLOUT_STRUCT BiosCallouts[] =
|
||||
|
|
@ -35,8 +35,7 @@ const BIOS_CALLOUT_STRUCT BiosCallouts[] =
|
|||
{AGESA_RUNFUNC_ONAP, agesa_RunFuncOnAp },
|
||||
{AGESA_GET_IDS_INIT_DATA, agesa_EmptyIdsInitData },
|
||||
{AGESA_HOOKBEFORE_DQS_TRAINING, agesa_NoopSuccess },
|
||||
{AGESA_HOOKBEFORE_EXIT_SELF_REF, agesa_NoopSuccess },
|
||||
{AGESA_FCH_OEM_CALLOUT, Fch_Oem_config }
|
||||
{AGESA_HOOKBEFORE_EXIT_SELF_REF, agesa_NoopSuccess }
|
||||
};
|
||||
const int BiosCalloutsLen = ARRAY_SIZE(BiosCallouts);
|
||||
|
||||
|
|
@ -57,17 +56,8 @@ static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
|
|||
FchParams->Hwm.HwmFchtsiAutoPoll = FALSE; /* 1 enable, 0 disable TSI Auto Polling */
|
||||
}
|
||||
|
||||
/**
|
||||
* Fch Oem setting callback
|
||||
*
|
||||
* Configure platform specific Hudson device,
|
||||
* such Azalia, SATA, IMC etc.
|
||||
*/
|
||||
static AGESA_STATUS Fch_Oem_config(UINT32 Func, UINTN FchData, VOID *ConfigPtr)
|
||||
void board_FCH_InitReset(struct sysinfo *cb_NA, FCH_RESET_DATA_BLOCK *FchParams)
|
||||
{
|
||||
AMD_CONFIG_PARAMS *StdHeader = (AMD_CONFIG_PARAMS *)ConfigPtr;
|
||||
if (StdHeader->Func == AMD_INIT_RESET) {
|
||||
FCH_RESET_DATA_BLOCK *FchParams = (FCH_RESET_DATA_BLOCK *) FchData;
|
||||
printk(BIOS_DEBUG, "Fch OEM config in INIT RESET ");
|
||||
//FchParams_reset->EcChannel0 = TRUE; /* logical devicd 3 */
|
||||
FchParams->LegacyFree = CONFIG(HUDSON_LEGACY_FREE);
|
||||
|
|
@ -75,8 +65,11 @@ static AGESA_STATUS Fch_Oem_config(UINT32 Func, UINTN FchData, VOID *ConfigPtr)
|
|||
FchParams->FchReset.IdeEnable = hudson_ide_enable();
|
||||
FchParams->FchReset.Xhci0Enable = CONFIG(HUDSON_XHCI_ENABLE);
|
||||
FchParams->FchReset.Xhci1Enable = FALSE;
|
||||
} else if (StdHeader->Func == AMD_INIT_ENV) {
|
||||
FCH_DATA_BLOCK *FchParams = (FCH_DATA_BLOCK *)FchData;
|
||||
printk(BIOS_DEBUG, "Done\n");
|
||||
}
|
||||
|
||||
void board_FCH_InitEnv(struct sysinfo *cb_NA, FCH_DATA_BLOCK *FchParams)
|
||||
{
|
||||
printk(BIOS_DEBUG, "Fch OEM config in INIT ENV ");
|
||||
|
||||
|
||||
|
|
@ -105,7 +98,8 @@ static AGESA_STATUS Fch_Oem_config(UINT32 Func, UINTN FchData, VOID *ConfigPtr)
|
|||
FchParams->Usb.Ehci2Enable = TRUE;
|
||||
|
||||
/* sata configuration */
|
||||
FchParams->Sata.SataDevSlpPort0 = 0; // Disable DEVSLP0 and 1 to make sure GPIO55 and 59 are not used by DEVSLP
|
||||
// Disable DEVSLP0 and 1 to make sure GPIO55 and 59 are not used by DEVSLP
|
||||
FchParams->Sata.SataDevSlpPort0 = 0;
|
||||
FchParams->Sata.SataDevSlpPort1 = 0;
|
||||
|
||||
FchParams->Sata.SataClass = CONFIG_HUDSON_SATA_MODE;
|
||||
|
|
@ -122,10 +116,7 @@ static AGESA_STATUS Fch_Oem_config(UINT32 Func, UINTN FchData, VOID *ConfigPtr)
|
|||
FchParams->Sata.SataIdeMode = TRUE;
|
||||
break;
|
||||
}
|
||||
}
|
||||
printk(BIOS_DEBUG, "Done\n");
|
||||
|
||||
return AGESA_SUCCESS;
|
||||
}
|
||||
|
||||
static AGESA_STATUS board_ReadSpd_from_cbfs(UINT32 Func, UINTN Data, VOID *ConfigPtr)
|
||||
|
|
|
|||
|
|
@ -20,7 +20,6 @@ if BOARD_PCENGINES_APU2 || BOARD_PCENGINES_APU3 || BOARD_PCENGINES_APU4 || \
|
|||
|
||||
config BOARD_SPECIFIC_OPTIONS
|
||||
def_bool y
|
||||
select BINARYPI_LEGACY_WRAPPER
|
||||
select CPU_AMD_PI_00730F01
|
||||
select NORTHBRIDGE_AMD_PI_00730F01
|
||||
select SOUTHBRIDGE_AMD_PI_AVALON
|
||||
|
|
|
|||
|
|
@ -14,7 +14,7 @@
|
|||
*/
|
||||
|
||||
#include <AGESA.h>
|
||||
#include <northbridge/amd/pi/agesawrapper.h>
|
||||
#include <northbridge/amd/agesa/state_machine.h>
|
||||
|
||||
|
||||
static const PCIe_PORT_DESCRIPTOR PortList[] = {
|
||||
|
|
@ -76,25 +76,7 @@ static const PCIe_COMPLEX_DESCRIPTOR PcieComplex = {
|
|||
.DdiLinkList = NULL,
|
||||
};
|
||||
|
||||
/*---------------------------------------------------------------------------------------*/
|
||||
/**
|
||||
* OemCustomizeInitEarly
|
||||
*
|
||||
* Description:
|
||||
* This stub function will call the host environment through the binary block
|
||||
* interface (call-out port) to provide a user hook opportunity
|
||||
*
|
||||
* Parameters:
|
||||
* @param[in] *InitEarly
|
||||
*
|
||||
* @retval VOID
|
||||
*
|
||||
**/
|
||||
/*---------------------------------------------------------------------------------------*/
|
||||
VOID
|
||||
OemCustomizeInitEarly (
|
||||
IN OUT AMD_EARLY_PARAMS *InitEarly
|
||||
)
|
||||
void board_BeforeInitEarly(struct sysinfo *cb, AMD_EARLY_PARAMS *InitEarly)
|
||||
{
|
||||
InitEarly->GnbConfig.PcieComplexList = &PcieComplex;
|
||||
InitEarly->PlatformConfig.CStateMode = CStateModeC6;
|
||||
|
|
|
|||
|
|
@ -21,11 +21,8 @@
|
|||
#include <arch/cpu.h>
|
||||
#include <cpu/x86/lapic.h>
|
||||
#include <console/console.h>
|
||||
#include <timestamp.h>
|
||||
#include <cpu/amd/car.h>
|
||||
#include <northbridge/amd/agesa/state_machine.h>
|
||||
#include <northbridge/amd/pi/agesawrapper.h>
|
||||
#include <northbridge/amd/pi/agesawrapper_call.h>
|
||||
#include <cpu/x86/bist.h>
|
||||
#include <southbridge/amd/pi/hudson/hudson.h>
|
||||
#include <superio/nuvoton/common/nuvoton.h>
|
||||
|
|
@ -40,9 +37,11 @@
|
|||
|
||||
static void early_lpc_init(void);
|
||||
|
||||
void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
|
||||
void board_BeforeAgesa(struct sysinfo *cb)
|
||||
{
|
||||
u32 val;
|
||||
pci_devfn_t dev;
|
||||
u32 data;
|
||||
|
||||
/*
|
||||
* In Hudson RRG, PMIOxD2[5:4] is "Drive strength control for
|
||||
|
|
@ -52,18 +51,11 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
|
|||
* the SoC BKDGs. Without this setting, there is no serial
|
||||
* output.
|
||||
*/
|
||||
outb(0xD2, 0xcd6);
|
||||
outb(0xd2, 0xcd6);
|
||||
outb(0x00, 0xcd7);
|
||||
|
||||
hudson_lpc_port80();
|
||||
|
||||
if (!cpu_init_detectedx && boot_cpu()) {
|
||||
pci_devfn_t dev;
|
||||
u32 data;
|
||||
|
||||
timestamp_init(timestamp_get());
|
||||
timestamp_add_now(TS_START_ROMSTAGE);
|
||||
|
||||
post_code(0x30);
|
||||
early_lpc_init();
|
||||
|
||||
|
|
@ -82,55 +74,16 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
|
|||
else if (CONFIG_UART_FOR_CONSOLE == 0)
|
||||
nuvoton_enable_serial(SERIAL1_DEV, CONFIG_TTYS0_BASE);
|
||||
|
||||
console_init();
|
||||
}
|
||||
|
||||
/* Halt if there was a built in self test failure */
|
||||
post_code(0x34);
|
||||
report_bist_failure(bist);
|
||||
|
||||
/* Load MPB */
|
||||
val = cpuid_eax(1);
|
||||
printk(BIOS_DEBUG, "BSP Family_Model: %08x\n", val);
|
||||
printk(BIOS_DEBUG, "cpu_init_detectedx = %08lx\n", cpu_init_detectedx);
|
||||
|
||||
post_code(0x37);
|
||||
AGESAWRAPPER(amdinitreset);
|
||||
|
||||
post_code(0x38);
|
||||
printk(BIOS_DEBUG, "Got past avalon_early_setup\n");
|
||||
|
||||
post_code(0x39);
|
||||
AGESAWRAPPER(amdinitearly);
|
||||
|
||||
/* Disable SVI2 controller to wait for command completion */
|
||||
val = pci_read_config32(PCI_DEV(0, 0x18, 5), 0x12C);
|
||||
if (val & (1 << 30)) {
|
||||
printk(BIOS_DEBUG, "SVI2 Wait completion disabled\n");
|
||||
} else {
|
||||
printk(BIOS_DEBUG, "Disabling SVI2 Wait completion\n");
|
||||
if (!(val & (1 << 30))) {
|
||||
val |= (1 << 30);
|
||||
pci_write_config32(PCI_DEV(0, 0x18, 5), 0x12C, val);
|
||||
}
|
||||
|
||||
timestamp_add_now(TS_BEFORE_INITRAM);
|
||||
|
||||
post_code(0x40);
|
||||
AGESAWRAPPER(amdinitpost);
|
||||
|
||||
/* FIXME: Detect if TSC frequency changed during raminit? */
|
||||
timestamp_rescale_table(1, 4);
|
||||
|
||||
timestamp_add_now(TS_AFTER_INITRAM);
|
||||
}
|
||||
|
||||
void agesa_postcar(struct sysinfo *cb)
|
||||
{
|
||||
//PspMboxBiosCmdDramInfo();
|
||||
post_code(0x41);
|
||||
AGESAWRAPPER(amdinitenv);
|
||||
|
||||
outb(0xEA, 0xCD6);
|
||||
/* Disable PCI-PCI bridge and release GPIO32/33 for other uses. */
|
||||
outb(0xea, 0xcd6);
|
||||
outb(0x1, 0xcd7);
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Reference in New Issue