mainboard/intel/mohonpeak: code cleanup

Code cleanup requested in commit 90957f88 -
"mainboard/intel: Add Mohon Peak CRB for Intel's atom c2000"

- Change com2 to COM2 in Kconfig text
- clean up includes of headers
- fix whitespace

Change-Id: I828bc4781ee7de95be5546206c5d6033b75293d9
Signed-off-by: Martin Roth <martin.roth@se-eng.com>
Reviewed-on: http://review.coreboot.org/6607
Tested-by: build bot (Jenkins)
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
This commit is contained in:
Martin Roth 2014-08-11 12:51:38 -06:00 committed by Martin Roth
parent 174a891121
commit f7a7ec09d8
5 changed files with 12 additions and 37 deletions

View File

@ -94,6 +94,6 @@ config UART_FOR_CONSOLE
int int
default 1 default 1
help help
The Mohon Peak board uses com2 (2f8) for the serial console. The Mohon Peak board uses COM2 (2f8) for the serial console.
endif # BOARD_INTEL_MOHONPEAK endif # BOARD_INTEL_MOHONPEAK

View File

@ -30,15 +30,14 @@
#include <device/pci.h> #include <device/pci.h>
#include <device/pci_ids.h> #include <device/pci_ids.h>
#include <cpu/x86/msr.h> #include <cpu/x86/msr.h>
#include "northbridge/intel/fsp_rangeley/northbridge.h" #include <southbridge/intel/fsp_rangeley/nvs.h>
#include <northbridge/intel/fsp_rangeley/northbridge.h>
extern const unsigned char AmlCode[]; extern const unsigned char AmlCode[];
#if CONFIG_HAVE_ACPI_SLIC #if CONFIG_HAVE_ACPI_SLIC
unsigned long acpi_create_slic(unsigned long current); unsigned long acpi_create_slic(unsigned long current);
#endif #endif
#include "southbridge/intel/fsp_rangeley/nvs.h"
static global_nvs_t *gnvs_; static global_nvs_t *gnvs_;
static void acpi_create_gnvs(global_nvs_t *gnvs) static void acpi_create_gnvs(global_nvs_t *gnvs)

View File

@ -20,7 +20,7 @@
#ifndef MOHONPEAK_GPIO_H #ifndef MOHONPEAK_GPIO_H
#define MOHONPEAK_GPIO_H #define MOHONPEAK_GPIO_H
#include "southbridge/intel/fsp_rangeley/gpio.h" #include <southbridge/intel/fsp_rangeley/gpio.h>
/* Core GPIO */ /* Core GPIO */
const struct soc_gpio soc_gpio_mode = { const struct soc_gpio soc_gpio_mode = {
@ -175,4 +175,4 @@ const struct soc_gpio_map gpio_map = {
}, },
}; };
#endif #endif /* MOHONPEAK_GPIO_H */

View File

@ -18,22 +18,7 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/ */
#include <types.h>
#include <string.h>
#include <device/device.h> #include <device/device.h>
#include <device/device.h>
#include <device/pci_def.h>
#include <device/pci_ops.h>
#include <console/console.h>
#if CONFIG_VGA_ROM_RUN
#include <x86emu/x86emu.h>
#endif
#include <pc80/mc146818rtc.h>
#include <arch/acpi.h>
#include <arch/io.h>
#include <arch/interrupt.h>
#include <boot/coreboot_tables.h>
#include <southbridge/intel/fsp_rangeley/soc.h>
/* /*
* mainboard_enable is executed as first thing after enumerate_buses(). * mainboard_enable is executed as first thing after enumerate_buses().

View File

@ -19,36 +19,27 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/ */
#include <stdint.h>
#include <string.h>
#include <lib.h>
#include <timestamp.h>
#include <arch/io.h> #include <arch/io.h>
#include <device/pci_def.h> #include <device/pci_def.h>
#include <device/pnp_def.h> #include <device/pnp_def.h>
#include <cpu/x86/lapic.h> #include <cpu/x86/lapic.h>
#include <pc80/mc146818rtc.h>
#include <cbmem.h>
#include <console/console.h>
#include <drivers/intel/fsp/fsp_util.h> #include <drivers/intel/fsp/fsp_util.h>
#include <northbridge/intel/fsp_rangeley/northbridge.h>
#include <southbridge/intel/fsp_rangeley/soc.h> #include <southbridge/intel/fsp_rangeley/soc.h>
#include <southbridge/intel/fsp_rangeley/gpio.h> #include <southbridge/intel/fsp_rangeley/gpio.h>
#include <southbridge/intel/fsp_rangeley/romstage.h> #include <southbridge/intel/fsp_rangeley/romstage.h>
#include <arch/cpu.h> #include <arch/cpu.h>
#include <cpu/x86/msr.h>
#include "gpio.h" #include "gpio.h"
static void interrupt_routing_config(void) static void interrupt_routing_config(void)
{ {
u32 ilb_base = pci_read_config32(SOC_LPC_DEV, IBASE) & ~0xf; u32 ilb_base = pci_read_config32(SOC_LPC_DEV, IBASE) & ~0xf;
/* /*
* Initialize Interrupt Routings for each device in ilb_base_address. * Initialize Interrupt Routings for each device in ilb_base_address.
* IR01 map to PCIe device 0x01 ... IR31 to device 0x1F. * IR01 map to PCIe device 0x01 ... IR31 to device 0x1F.
* PIRQ_A maps to IRQ 16 ... PIRQ_H maps tp IRQ 23. * PIRQ_A maps to IRQ 16 ... PIRQ_H maps tp IRQ 23.
* This should match devicetree and the ACPI IRQ routing/ * This should match devicetree and the ACPI IRQ routing/
*/ */
write32(ilb_base + ILB_ACTL, 0x0000); /* ACTL bit 2:0 SCIS IRQ9 */ write32(ilb_base + ILB_ACTL, 0x0000); /* ACTL bit 2:0 SCIS IRQ9 */
write16(ilb_base + ILB_IR01, 0x3210); /* IR01h IR(ABCD) - PIRQ(ABCD) */ write16(ilb_base + ILB_IR01, 0x3210); /* IR01h IR(ABCD) - PIRQ(ABCD) */
write16(ilb_base + ILB_IR02, 0x3210); /* IR02h IR(ABCD) - PIRQ(ABCD) */ write16(ilb_base + ILB_IR02, 0x3210); /* IR02h IR(ABCD) - PIRQ(ABCD) */