GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

arch/power8/tables: remove confusion over write_tables() 

Apparently the memo was missed about the write_tables()
signature. Fix the confusion.

Change-Id: I63924be47d3507d2d7ed006a553414f4ac60d2f9
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/14420
Tested-by: build bot (Jenkins)
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Aaron Durbin 2016-04-19 13:41:16 -05:00
parent 581c42807d
commit f7dca0a275
1 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/arch/power8/tables.c
View File

@ -25,8 +25,7 @@
#define MAX_COREBOOT_TABLE_SIZE (8 * 1024) #define MAX_COREBOOT_TABLE_SIZE (8 * 1024)
// WTF. this does not agree with the prototype! void write_tables(void)
static struct lb_memory *wtf_write_tables(void)
{ {
unsigned long table_pointer, new_table_pointer; unsigned long table_pointer, new_table_pointer;
@ -36,7 +35,7 @@ static struct lb_memory *wtf_write_tables(void)
MAX_COREBOOT_TABLE_SIZE); MAX_COREBOOT_TABLE_SIZE);
if (!table_pointer) { if (!table_pointer) {
printk(BIOS_ERR, "Could not add CBMEM for coreboot table.\n"); printk(BIOS_ERR, "Could not add CBMEM for coreboot table.\n");
return NULL; return;
} }
new_table_pointer = write_coreboot_table(0UL, 0UL, new_table_pointer = write_coreboot_table(0UL, 0UL,
@ -55,16 +54,8 @@ static struct lb_memory *wtf_write_tables(void)
/* Print CBMEM sections */ /* Print CBMEM sections */
cbmem_list(); cbmem_list();
// return get_lb_mem();
return NULL;
} }
void lb_arch_add_records(struct lb_header *header) void lb_arch_add_records(struct lb_header *header)
{ {
} }
void write_tables(void)
{
wtf_write_tables();
}