GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/skylake: Send correct ddr_type to SMBIOS Table 

The FSP 2.0 Memory_Info_HOB for KBL is not sending
"MemoryType" value as what is required for SMBIOS Table
according to SMBIOS Spec. Thus, converting the value
retrieved from FSP HOB to the correct value.

This change will not be required for upcoming SOCs since
FSP have fixed this issue in its next platforms and thus it
will take care and send the correct value in "MemoryType"
field based on SMBIOS spec. Thus this conversion from coreboot
will not be required in the next platfoms. "MemoryType" value
can be directly passed to dimm_info_fill() function.

BUG=none
BRANCH=none
TEST=Tested in Soraka, and getting the value as 0x1D for
LPDDR3 memory. dmidecode (latest version 3.1) Command Type 17
will also show correct information. Currently, it was showing
"Unknown".

Change-Id: I75d6cca464680a88bf836e25bf5440a9cdbc738e
Signed-off-by: Barnali Sarkar <barnali.sarkar@intel.com>
Reviewed-on: https://review.coreboot.org/23384
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Barnali Sarkar 2018-01-11 16:40:54 +05:30 committed by Subrata Banik
parent a2fc1aee44
commit f7f01f70a4
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/soc/intel/skylake/romstage/romstage_fsp20.c
View File

@ -28,6 +28,7 @@
#include <fsp/memmap.h>
#include <intelblocks/pmclib.h>
#include <memory_info.h>
#include <smbios.h>
#include <soc/intel/common/smbios.h>
#include <soc/msr.h>
#include <soc/pci_devs.h>
@ -48,6 +49,7 @@ static void save_dimm_info(void)
{
int channel, dimm, dimm_max, index;
size_t hob_size;
uint8_t ddr_type;
const CONTROLLER_INFO *ctrlr_info;
const CHANNEL_INFO *channel_info;
const DIMM_INFO *src_dimm;
@ -91,10 +93,25 @@ static void save_dimm_info(void)
if (src_dimm->Status != DIMM_PRESENT)
continue;
switch(memory_info_hob->MemoryType) {
case MRC_DDR_TYPE_DDR4:
ddr_type = MEMORY_DEVICE_DDR4;
break;
case MRC_DDR_TYPE_DDR3:
ddr_type = MEMORY_DEVICE_DDR3;
break;
case MRC_DDR_TYPE_LPDDR3:
ddr_type = MEMORY_DEVICE_LPDDR3;
break;
default:
ddr_type = MEMORY_DEVICE_UNKNOWN;
break;
}
/* Populate the DIMM information */
dimm_info_fill(dest_dimm,
src_dimm->DimmCapacity,
memory_info_hob->MemoryType,
ddr_type,
memory_info_hob->ConfiguredMemoryClockSpeed,
channel_info->ChannelId,
src_dimm->DimmId,