GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/block/gpio_banks: use unsigned int for gevent parameter 

A valid GEVENT number is never negative. The local variable in
set_single_gpio still needs to be a signed integer, since the return
value of get_gpio_gevent being -1 indicates that the GPIO can't generate
a GEVENT. The check for that makes the function return before calling
program_smi of program_sci, so the parameter of those functions can be
changed to unsigned.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I6ce23ceed1585589932824b8cab2a138328672a9
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56705
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Held 2021-07-30 03:26:15 +02:00
parent df566ae428
commit f80e6d6f56
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/amd/common/block/gpio_banks/gpio.c
View File

@ -27,7 +27,7 @@ static int get_gpio_gevent(gpio_t gpio, const struct soc_amd_event *table,
return -1; return -1;
} }
static void program_smi(uint32_t flags, int gevent_num) static void program_smi(uint32_t flags, unsigned int gevent_num)
{ {
uint8_t level; uint8_t level;
@ -52,7 +52,7 @@ static void program_smi(uint32_t flags, int gevent_num)
* In a similar fashion, polarity (rising/falling, hi/lo) of each GPE is * In a similar fashion, polarity (rising/falling, hi/lo) of each GPE is
* represented as a single bit in SMI_SCI_TRIG register. * represented as a single bit in SMI_SCI_TRIG register.
*/ */
static void program_sci(uint32_t flags, int gevent_num) static void program_sci(uint32_t flags, unsigned int gevent_num)
{ {
struct sci_source sci; struct sci_source sci;