GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/fsp/Makefile: check if CONFIG_FSP_M_FILE is defined 

When CONFIG_FSP_M_FILE isn't defined, the parameter of the file-size
call evaluates to an empty string, so the file-size call will run
"cat | wc -c" which will cause make to get stuck in there. Also print a
message when no FSP-M file is specified that the resulting image won't
boot successfully.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I6b02774e2c79d12554fd076aa01bbe972176f372
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57189
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Felix Held 2021-08-27 04:11:10 +02:00 committed by Felix Held
parent 30bfcaba39
commit f8df08213d
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/amd/common/fsp/Makefile.inc
View File

@ -7,11 +7,15 @@ ramstage-$(CONFIG_SOC_AMD_COMMON_FSP_DMI_TABLES) += dmi.c
subdirs-y += ./*
ifeq ($(CONFIG_FSP_M_FILE),)
$(info There's no FSP-M binary file specified. The resulting image won't boot successfully.)
else
ifeq ($(call int-gt,\
$(call file-size,$(call strip_quotes,$(CONFIG_FSP_M_FILE)))\
$(shell printf "%d" $(CONFIG_FSP_M_SIZE))),\
1)
$(error FSP-M binary larger than FSP_M_FILE.)
endif
endif # CONFIG_FSP_M_FILE
endif # CONFIG_PLATFORM_USES_FSP2_0