GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add delay before reading GPIOs in gpio_base2_value() 

This adds a 10us delay in between (re-)configuring and reading
GPIOs in gpio_base2_value() to give the values stored some time
to update.

As far as I know this hasn't bitten us since the function was
added, but adding a short delay here seems like the right thing
to do.

BUG=none
BRANCH=none
TEST=built and booted on Brain

Change-Id: I869cf375680435ad87729f93d29a623bdf09dfbc
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: 2484900fc9ceba87220a293de8ef20c3b9b20cfd
Original-Signed-off-by: David Hendricks <dhendrix@chromium.org>
Original-Change-Id: I79616a09d8d2ce4e416ffc94e35798dd25a6250d
Original-Reviewed-on: https://chromium-review.googlesource.com/240854
Original-Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: http://review.coreboot.org/9725
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
David Hendricks 2015-01-14 20:41:30 -08:00 committed by Patrick Georgi
parent 92da778d32
commit f9b49e8782
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/lib/gpio.c
View File

@ -26,10 +26,14 @@ int gpio_base2_value(gpio_t gpio[], int num_gpio)
{ {
int i, result = 0; int i, result = 0;
for (i = 0; i < num_gpio; i++) { for (i = 0; i < num_gpio; i++)
gpio_input(gpio[i]); gpio_input(gpio[i]);
/* Wait until signals become stable */
udelay(10);
for (i = 0; i < num_gpio; i++)
result |= gpio_get(gpio[i]) << i; result |= gpio_get(gpio[i]) << i;
}
return result; return result;
} }