GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

acpi/acpi.h: Remove global acpi_fill_ivrs_ioapic() 

In soc/amd this function is unused so drop it and rename
_acpi_fill_ivrs_ioapic().

Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Change-Id: Ic403fd84cb9cd5805fbc6f0c5a64cefbf4b0cd81
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75711
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Naresh <naresh.solanki.2011@gmail.com>
This commit is contained in:
Arthur Heymans 2023-06-07 15:29:02 +02:00 committed by Martin L Roth
parent ce179729f0
commit f9ee87ffbf
3 changed files with 4 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/include/acpi/acpi.h
View File

@ -1337,7 +1337,6 @@ unsigned long fw_cfg_acpi_tables(unsigned long start);
void preload_acpi_dsdt(void);
unsigned long write_acpi_tables(unsigned long addr);
unsigned long acpi_fill_madt(unsigned long current);
unsigned long acpi_fill_ivrs_ioapic(acpi_ivrs_t *ivrs, unsigned long current);
void acpi_fill_fadt(acpi_fadt_t *fadt);
void arch_fill_fadt(acpi_fadt_t *fadt);

2
src/northbridge/amd/pi/00730F01/northbridge.c
View File

@ -242,7 +242,7 @@ static unsigned long acpi_fill_hest(acpi_hest_t *hest)
return (unsigned long)current;
}
unsigned long acpi_fill_ivrs_ioapic(acpi_ivrs_t *ivrs, unsigned long current)
static unsigned long acpi_fill_ivrs_ioapic(acpi_ivrs_t *ivrs, unsigned long current)
{
/* 8-byte IVHD structures must be aligned to the 8-byte boundary. */
current = ALIGN_UP(current, 8);

18
src/soc/amd/common/block/acpi/ivrs.c
View File

@ -17,7 +17,7 @@
#include <soc/iomap.h>
#include <soc/pci_devs.h>
static unsigned long _acpi_fill_ivrs_ioapic(unsigned long current, void *ioapic_base,
static unsigned long acpi_fill_ivrs_ioapic(unsigned long current, void *ioapic_base,
uint16_t src_devid, uint8_t dte_setting)
{
ivrs_ivhd_special_t *ivhd_ioapic = (ivrs_ivhd_special_t *)current;
@ -33,18 +33,6 @@ static unsigned long _acpi_fill_ivrs_ioapic(unsigned long current, void *ioapic_
return current;
}
unsigned long acpi_fill_ivrs_ioapic(acpi_ivrs_t *ivrs, unsigned long current)
{
uint32_t dte_setting = IVHD_DTE_LINT_1_PASS | IVHD_DTE_LINT_0_PASS |
IVHD_DTE_SYS_MGT_NO_TRANS | IVHD_DTE_NMI_PASS |
IVHD_DTE_EXT_INT_PASS | IVHD_DTE_INIT_PASS;
current = _acpi_fill_ivrs_ioapic(current, VIO_APIC_VADDR,
SMBUS_DEVFN, dte_setting);
return _acpi_fill_ivrs_ioapic(current, (u8 *)GNB_IO_APIC_ADDR,
PCI_DEVFN(0, 1), 0);
}
static unsigned long ivhd_describe_hpet(unsigned long current, uint8_t hndl, uint16_t src_devid)
{
ivrs_ivhd_special_t *ivhd_hpet = (ivrs_ivhd_special_t *)current;
@ -204,7 +192,7 @@ static unsigned long acpi_ivhd_misc(unsigned long current, struct device *dev)
res = probe_resource(dev, IOMMU_IOAPIC_IDX);
if (res) {
/* Describe IOAPIC associated with the IOMMU */
current = _acpi_fill_ivrs_ioapic(current, (u8 *)(uintptr_t)res->base,
current = acpi_fill_ivrs_ioapic(current, (u8 *)(uintptr_t)res->base,
PCI_DEVFN(0, 1) | (dev->link_list->secondary << 8), 0);
}
@ -213,7 +201,7 @@ static unsigned long acpi_ivhd_misc(unsigned long current, struct device *dev)
/* Describe HPET */
current = ivhd_describe_hpet(current, 0x00, SMBUS_DEVFN);
/* Describe FCH IOAPICs */
current = _acpi_fill_ivrs_ioapic(current, VIO_APIC_VADDR,
current = acpi_fill_ivrs_ioapic(current, VIO_APIC_VADDR,
SMBUS_DEVFN, dte_setting);
}