GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/bincfg: Clean up Makefile 

- Enable warnings
- Enable warnings as errors
- Remove debug flag -g
- Add targets for all, distclean, and help
- Add dependency of the bincfg file for output targets
- Add all phony targets to .PHONY

BUG=None
TEST=Build all targets

Signed-off-by: Martin Roth <martin@coreboot.org>
Change-Id: Ic0302f663cbc931325334d0cce93d3b0bf937cc6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50654
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Martin Roth 2021-02-13 23:24:12 -07:00 committed by Martin Roth
parent 7bbcdc2f20
commit fa9eb951d4
1 changed files with 24 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
util/bincfg/Makefile
View File

@ -2,9 +2,15 @@ CC = gcc
YACC = bison YACC = bison
LEX = flex LEX = flex
TARGET=bincfg TARGET=bincfg
WERROR=-Werror
CFLAGS=-O2 -Wall -Wextra -Wshadow ${WERROR}
CFLAGS+=-Wno-unused-function
LDFLAGS= -lfl
all: $(TARGET)
$(TARGET): $(TARGET).lex.o $(TARGET).tab.o $(TARGET): $(TARGET).lex.o $(TARGET).tab.o
$(CC) $^ -Wall -Wno-unused-function -g -lfl -o $@ $(CC) $^ $(CFLAGS) $(LDFLAGS) -o $@
$(TARGET).lex.c: $(TARGET).l $(TARGET).tab.h $(TARGET).lex.c: $(TARGET).l $(TARGET).tab.h
$(LEX) -o $(patsubst $(TARGET).l,$(TARGET).lex.c,$<) $< $(LEX) -o $(patsubst $(TARGET).l,$(TARGET).lex.c,$<) $<
@ -13,24 +19,36 @@ $(TARGET).tab.c $(TARGET).tab.h: $(TARGET).y
$(YACC) -d $< $(YACC) -d $<
# Use this target to generate GbE for X200 # Use this target to generate GbE for X200
gen-gbe-ich9m: gen-gbe-ich9m: $(TARGET)
./bincfg gbe-ich9m.spec gbe-ich9m.set gbe1.bin ./bincfg gbe-ich9m.spec gbe-ich9m.set gbe1.bin
# duplicate binary as per spec # duplicate binary as per spec
cat gbe1.bin gbe1.bin > flashregion_3_gbe.bin cat gbe1.bin gbe1.bin > flashregion_3_gbe.bin
rm -f gbe1.bin rm -f gbe1.bin
# Use this target to generate GbE for X220/x230 # Use this target to generate GbE for X220/x230
gen-gbe-82579LM: gen-gbe-82579LM: $(TARGET)
./bincfg gbe-82579LM.spec gbe-82579LM.set gbe1.bin ./bincfg gbe-82579LM.spec gbe-82579LM.set gbe1.bin
# duplicate binary as per spec # duplicate binary as per spec
cat gbe1.bin gbe1.bin > flashregion_3_gbe.bin cat gbe1.bin gbe1.bin > flashregion_3_gbe.bin
rm -f gbe1.bin rm -f gbe1.bin
# Use this target to generate IFD for X200 # Use this target to generate IFD for X200
gen-ifd-x200: gen-ifd-x200: $(TARGET)
./bincfg ifd-x200.spec ifd-x200.set flashregion_0_fd.bin ./bincfg ifd-x200.spec ifd-x200.set flashregion_0_fd.bin
.PHONY: clean gen-gbe-ich9m gen-ifd-x200
clean: clean:
rm -f *.lex.c *.tab.c *.tab.h *.o bincfg flashregion_0_fd.bin flashregion_3_gbe.bin rm -f *.lex.c *.tab.c *.tab.h *.o bincfg flashregion_0_fd.bin flashregion_3_gbe.bin
distclean: clean
help:
@echo "${TARGET}: Compiler/Decompiler for data blobs with specs"
@echo "Targets: all, clean, distclean, help"
@echo " gen-gbe-ich9m - generate GbE for X200"
@echo " gen-gbe-82579LM - generate GbE for X220/x230"
@echo " gen-ifd-x200 - generate IFD for X200"
@echo "To disable warnings as errors, run make as:"
@echo " make all WERROR=\"\""
.PHONY: all clean distclean help
.PHONY: gen-gbe-ich9m gen-ifd-x200 gen-gbe-82579LM