From face29cd50890e8f6647a2a7ec3e879989b86952 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Mon, 23 Oct 2023 19:06:13 -0600 Subject: [PATCH] security/intel/stm: Remove check that can never be true STM_RSC_MEM_DESC defines rws_attributes as 3 bits, which can't be greater than 7. Found-by: Coverity Scan #1430578 Signed-off-by: Martin Roth Change-Id: I1efd007e96abd6d5d36f314752abfadffb0024d1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/78619 Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- src/security/intel/stm/SmmStm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/security/intel/stm/SmmStm.c b/src/security/intel/stm/SmmStm.c index 3371f02efe..64a4877ed4 100644 --- a/src/security/intel/stm/SmmStm.c +++ b/src/security/intel/stm/SmmStm.c @@ -354,9 +354,6 @@ static bool validate_resource(STM_RSC *resource_list, uint32_t num_entries) if (resource->header.length != sizeof(STM_RSC_MEM_DESC)) return false; - - if (resource->mem.rwx_attributes > FULL_ACCS) - return false; break; case IO_RANGE: