GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brya/variants/felwinter: Fix stylus UI behavior bug 

Fix stylus UI behavior bug.
1) it appears the kernel's gpio_key driver is not expecting
an IRQ descriptor for the `gpio` property, therefore change
to an active-low input.
2) The wakeup event was configured backwards.

Change list
- Configure GPP_A7 as "ACPI_GPIO_INPUT_ACTIVE_LOW".
- Change wakeup_event_action from ASSERTED to DEASSERTED.

BUG=b:220992812
TEST=emerge-brya coreboot chromeos-bootimage and verify pass

Signed-off-by: John Su <john_su@compal.corp-partner.google.com>
Change-Id: I6f5e2992584d759eb1a559684d1cda08c7cbe3f2
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62638
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
John Su 2022-03-07 15:34:54 +08:00 committed by Felix Held
parent c07d1bdc71
commit fadd0ff40a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/brya/variants/felwinter/overridetree.cb
View File

@ -275,10 +275,10 @@ chip soc/intel/alderlake
end end
chip drivers/generic/gpio_keys chip drivers/generic/gpio_keys
register "name" = ""PENH"" register "name" = ""PENH""
register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A7)" register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_A7)"
register "key.wake_gpe" = "GPE0_DW0_08" register "key.wake_gpe" = "GPE0_DW0_08"
register "key.wakeup_route" = "WAKEUP_ROUTE_SCI" register "key.wakeup_route" = "WAKEUP_ROUTE_SCI"
register "key.wakeup_event_action" = "EV_ACT_ASSERTED" register "key.wakeup_event_action" = "EV_ACT_DEASSERTED"
register "key.dev_name" = ""EJCT"" register "key.dev_name" = ""EJCT""
register "key.linux_code" = "SW_PEN_INSERTED" register "key.linux_code" = "SW_PEN_INSERTED"
register "key.linux_input_type" = "EV_SW" register "key.linux_input_type" = "EV_SW"