inteltool: Add function to generate SPD dump.

E.g. on my MacbookAir to generate spd.bin to be used
with coreboot I do:

./inteltool -S spd.bin

Change-Id: If165475ed3e1f3262a8926ef619128d25b1e2896
Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
Reviewed-on: http://review.coreboot.org/11847
Tested-by: build bot (Jenkins)
Reviewed-by: Marc Jones <marc@marcjonesconsulting.com>
This commit is contained in:
Vladimir Serbinenko 2015-10-10 13:20:32 +02:00
parent cd19f7d867
commit fb69a69fce
4 changed files with 41 additions and 7 deletions

View File

@ -228,6 +228,7 @@ void print_usage(const char *name)
" -r | --rcba: dump southbridge RCBA registers\n" " -r | --rcba: dump southbridge RCBA registers\n"
" -p | --pmbase: dump southbridge Power Management registers\n\n" " -p | --pmbase: dump southbridge Power Management registers\n\n"
" -m | --mchbar: dump northbridge Memory Controller registers\n" " -m | --mchbar: dump northbridge Memory Controller registers\n"
" -S FILE | --spd=FILE: generate spd.bin equivalent to current timings\n"
" -e | --epbar: dump northbridge EPBAR registers\n" " -e | --epbar: dump northbridge EPBAR registers\n"
" -d | --dmibar: dump northbridge DMIBAR registers\n" " -d | --dmibar: dump northbridge DMIBAR registers\n"
" -P | --pciexpress: dump northbridge PCIEXBAR registers\n\n" " -P | --pciexpress: dump northbridge PCIEXBAR registers\n\n"
@ -242,6 +243,7 @@ int main(int argc, char *argv[])
{ {
struct pci_access *pacc; struct pci_access *pacc;
struct pci_dev *sb = NULL, *nb, *gfx = NULL, *dev; struct pci_dev *sb = NULL, *nb, *gfx = NULL, *dev;
const char *dump_spd_file = 0;
int i, opt, option_index = 0; int i, opt, option_index = 0;
unsigned int id; unsigned int id;
@ -267,18 +269,23 @@ int main(int argc, char *argv[])
{"msrs", 0, 0, 'M'}, {"msrs", 0, 0, 'M'},
{"ambs", 0, 0, 'A'}, {"ambs", 0, 0, 'A'},
{"spi", 0, 0, 's'}, {"spi", 0, 0, 's'},
{"spd", 0, 0, 'S'},
{"all", 0, 0, 'a'}, {"all", 0, 0, 'a'},
{"gfx", 0, 0, 'f'}, {"gfx", 0, 0, 'f'},
{0, 0, 0, 0} {0, 0, 0, 0}
}; };
while ((opt = getopt_long(argc, argv, "vh?gGrpmedPMaAsf", while ((opt = getopt_long(argc, argv, "vh?gGrpmedPMaAsfS:",
long_options, &option_index)) != EOF) { long_options, &option_index)) != EOF) {
switch (opt) { switch (opt) {
case 'v': case 'v':
print_version(); print_version();
exit(0); exit(0);
break; break;
case 'S':
dump_spd_file = optarg;
dump_mchbar = 1;
break;
case 'g': case 'g':
dump_gpios = 1; dump_gpios = 1;
break; break;
@ -467,7 +474,7 @@ int main(int argc, char *argv[])
} }
if (dump_mchbar) { if (dump_mchbar) {
print_mchbar(nb, pacc); print_mchbar(nb, pacc, dump_spd_file);
printf("\n\n"); printf("\n\n");
} }

View File

@ -204,7 +204,7 @@ void unmap_physical(void *virt_addr, size_t len);
unsigned int cpuid(unsigned int op); unsigned int cpuid(unsigned int op);
int print_intel_core_msrs(void); int print_intel_core_msrs(void);
int print_mchbar(struct pci_dev *nb, struct pci_access *pacc); int print_mchbar(struct pci_dev *nb, struct pci_access *pacc, const char *dump_spd_file);
int print_pmbase(struct pci_dev *sb, struct pci_access *pacc); int print_pmbase(struct pci_dev *sb, struct pci_access *pacc);
int print_rcba(struct pci_dev *sb); int print_rcba(struct pci_dev *sb);
int print_gpios(struct pci_dev *sb, int show_all, int show_diffs); int print_gpios(struct pci_dev *sb, int show_all, int show_diffs);
@ -214,4 +214,4 @@ int print_pciexbar(struct pci_dev *nb);
int print_ambs(struct pci_dev *nb, struct pci_access *pacc); int print_ambs(struct pci_dev *nb, struct pci_access *pacc);
int print_spi(struct pci_dev *sb); int print_spi(struct pci_dev *sb);
int print_gfx(struct pci_dev *gfx); int print_gfx(struct pci_dev *gfx);
void ivybridge_dump_timings(void); void ivybridge_dump_timings(const char *dump_spd_file);

View File

@ -19,6 +19,7 @@
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <inttypes.h> #include <inttypes.h>
#include <errno.h>
#include "inteltool.h" #include "inteltool.h"
extern volatile uint8_t *mchbar; extern volatile uint8_t *mchbar;
@ -69,7 +70,7 @@ static u16 spd_ddr3_calc_crc(u8 * spd)
return crc; return crc;
} }
void ivybridge_dump_timings(void) void ivybridge_dump_timings(const char *dump_spd_file)
{ {
u32 mr0[2]; u32 mr0[2];
u32 mr1[2]; u32 mr1[2];
@ -362,8 +363,20 @@ void ivybridge_dump_timings(void)
printf("/* SPD matching current mode: */\n"); printf("/* SPD matching current mode: */\n");
FILE *dump_spd = 0;
if (dump_spd_file) {
dump_spd = fopen (dump_spd_file, "wb");
if (!dump_spd) {
fprintf (stderr, "Couldn't open file %s: %s\n", dump_spd_file,
strerror (errno));
exit (1);
}
}
for (channel = 0; channel < 2; channel++) for (channel = 0; channel < 2; channel++)
for (slot = 0; slot < 2; slot++) for (slot = 0; slot < 2; slot++)
{
if (slots[channel][slot].size_mb) { if (slots[channel][slot].size_mb) {
int i; int i;
@ -377,6 +390,20 @@ void ivybridge_dump_timings(void)
printf("\n"); printf("\n");
} }
printf("\n"); printf("\n");
if (dump_spd) {
fwrite(spd[channel][slot], 1, 256, dump_spd);
}
} else {
if (dump_spd) {
char zero[256];
memset (zero, 0, 256);
fwrite(zero, 1, 256, dump_spd);
}
} }
}
if (dump_spd) {
fclose (dump_spd);
}
} }

View File

@ -111,7 +111,7 @@ static void dump_timings (void)
/* /*
* (G)MCH MMIO Config Space * (G)MCH MMIO Config Space
*/ */
int print_mchbar(struct pci_dev *nb, struct pci_access *pacc) int print_mchbar(struct pci_dev *nb, struct pci_access *pacc, const char *dump_spd_file)
{ {
int i, size = (16 * 1024); int i, size = (16 * 1024);
uint64_t mchbar_phys; uint64_t mchbar_phys;
@ -265,7 +265,7 @@ int print_mchbar(struct pci_dev *nb, struct pci_access *pacc)
case PCI_DEVICE_ID_INTEL_CORE_3RD_GEN_M: case PCI_DEVICE_ID_INTEL_CORE_3RD_GEN_M:
case PCI_DEVICE_ID_INTEL_CORE_3RD_GEN_E3: case PCI_DEVICE_ID_INTEL_CORE_3RD_GEN_E3:
case PCI_DEVICE_ID_INTEL_CORE_3RD_GEN_015c: case PCI_DEVICE_ID_INTEL_CORE_3RD_GEN_015c:
ivybridge_dump_timings(); ivybridge_dump_timings(dump_spd_file);
break; break;
} }
unmap_physical((void *)mchbar, size); unmap_physical((void *)mchbar, size);