inteltool: improve the libpci test in the Makefile

Use the verbatim variable method to define and export test code and
the actual libpci test from flashrom. This improves readability and
will work with stricter compiler (settings).

Change-Id: Iace7d53b0b992c4fde596ce1d606ad715d6dfc2a
Signed-off-by: Stefan Tauner <stefan.tauner@gmx.at>
Reviewed-on: http://review.coreboot.org/1575
Tested-by: build bot (Jenkins)
Reviewed-by: Anton Kochkov <anton.kochkov@gmail.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Stefan Tauner 2012-10-12 10:36:49 +02:00 committed by Stefan Reinauer
parent 1a00cf0632
commit fba86bfaa8
1 changed files with 16 additions and 4 deletions

View File

@ -53,12 +53,24 @@ distclean: clean
dep: dep:
@$(CC) $(CFLAGS) -MM *.c > .dependencies @$(CC) $(CFLAGS) -MM *.c > .dependencies
define LIBPCI_TEST
/* Avoid a failing test due to libpci header symbol shadowing breakage */
#define index shadow_workaround_index
#include <pci/pci.h>
struct pci_access *pacc;
int main(int argc, char **argv)
{
(void) argc;
(void) argv;
pacc = pci_alloc();
return 0;
}
endef
export LIBPCI_TEST
pciutils: pciutils:
@printf "\nChecking for pciutils and zlib... " @printf "\nChecking for pciutils and zlib... "
@$(shell ( printf "#include <pci/pci.h>\n"; \ @echo "$$LIBPCI_TEST" > .test.c
printf "struct pci_access *pacc;\n"; \
printf "int main(int argc, char **argv)\n"; \
printf "{ pacc = pci_alloc(); return 0; }\n"; ) > .test.c )
@$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) >/dev/null 2>&1 && \ @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) >/dev/null 2>&1 && \
printf "found.\n" || ( printf "not found.\n\n"; \ printf "found.\n" || ( printf "not found.\n\n"; \
printf "Please install pciutils-devel and zlib-devel.\n"; \ printf "Please install pciutils-devel and zlib-devel.\n"; \