GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AMD cimx/sb800: Set SPI frequency and prefetch 

Broken with/since commit d1cb0eec.

Original intention was to set the frequency for 'Fast Read' command
in bits 15..14, and enable 'Fast Read' command.

Modified register contains SPI frequency for 'Normal Read' command
in bits 13..12. Default for this is 11b for 16.5 MHz. Existing code
unintentionally clears these bits, increasing SPI frequency to 66MHz
for 'Normal Read' command.

This is above specifications for many common SPI flash components
and also makes flashrom older than 0.9.7-r1750 to operate unreliably
on read/write/erase for these platforms.

Change-Id: I30109e2a0410c0bb0bdc968ea71787396b32e761
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/5089
Tested-by: build bot (Jenkins)
Reviewed-by: Kevin O'Connor <kevin@koconnor.net>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Marc Jones <marc.jones@se-eng.com>
This commit is contained in:
Kyösti Mälkki 2014-01-31 20:32:54 +02:00 committed by Marc Jones
parent d9b5d897d7
commit fbdbcb713f
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/southbridge/amd/cimx/sb800/bootblock.c
View File

@ -66,7 +66,6 @@ static void enable_prefetch(void)
static void enable_spi_fast_mode(void) static void enable_spi_fast_mode(void)
{ {
u8 byte;
u32 dword; u32 dword;
device_t dev = PCI_DEV(0, 0x14, 0x03); device_t dev = PCI_DEV(0, 0x14, 0x03);
@ -76,8 +75,8 @@ static void enable_spi_fast_mode(void)
pci_io_write_config32(dev, 0xa0, (u32) spi_base | 2); pci_io_write_config32(dev, 0xa0, (u32) spi_base | 2);
// early enable of SPI 33 MHz fast mode read // early enable of SPI 33 MHz fast mode read
byte = spi_base[3]; dword = spi_base[3];
spi_base[3] = (byte & ~(3 << 14)) | (1 << 14); spi_base[3] = (dword & ~(3 << 14)) | (1 << 14);
spi_base[0] = spi_base[0] | (1 << 18); // fast read enable spi_base[0] = spi_base[0] | (1 << 18); // fast read enable
pci_io_write_config32(dev, 0xa0, save); pci_io_write_config32(dev, 0xa0, save);