From fbf58d9f89450517d1d7d8543dede6781921258c Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Sun, 10 Apr 2022 10:07:09 +0200 Subject: [PATCH] ec/google/chromeec: Drop `_PRS` from static devices The `_PRS` ACPI object is not needed for static (non-configurable) devices. For devices where `_CRS` always provides the same set of resource settings, drop the `_PRS` object. Note that every dropped `_PRS` object only provides one set of resource settings, which is identical to the resource settings provided by the `_CRS` object. Change-Id: Ief40e790fdee336fd6c786e18cd01c41fa658c2c Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/63521 Tested-by: build bot (Jenkins) Reviewed-by: Felix Held Reviewed-by: Paul Menzel --- src/ec/google/chromeec/acpi/superio.asl | 46 ------------------------- 1 file changed, 46 deletions(-) diff --git a/src/ec/google/chromeec/acpi/superio.asl b/src/ec/google/chromeec/acpi/superio.asl index 05310be800..0620e09576 100644 --- a/src/ec/google/chromeec/acpi/superio.asl +++ b/src/ec/google/chromeec/acpi/superio.asl @@ -37,12 +37,6 @@ Device (SIO) { IO (Decode16, EC_LPC_ADDR_MEMMAP, EC_LPC_ADDR_MEMMAP, 0x08, EC_MEMMAP_SIZE) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, EC_LPC_ADDR_MEMMAP, EC_LPC_ADDR_MEMMAP, - 0x08, EC_MEMMAP_SIZE) - }) } #endif @@ -70,23 +64,6 @@ Device (SIO) { EC_HOST_CMD_REGION1, EC_HOST_CMD_REGION1, 0x08, EC_HOST_CMD_REGION_SIZE) }) - - Name (_PRS, ResourceTemplate () - { - StartDependentFn (0, 0) { - IO (Decode16, EC_LPC_ADDR_HOST_DATA, - EC_LPC_ADDR_HOST_DATA, 0x01, 0x01) - IO (Decode16, EC_LPC_ADDR_HOST_CMD, - EC_LPC_ADDR_HOST_CMD, 0x01, 0x01) - IO (Decode16, - EC_HOST_CMD_REGION0, EC_HOST_CMD_REGION0, - 0x08, EC_HOST_CMD_REGION_SIZE) - IO (Decode16, - EC_HOST_CMD_REGION1, EC_HOST_CMD_REGION1, - 0x08, EC_HOST_CMD_REGION_SIZE) - } - EndDependentFn () - }) } #endif @@ -104,15 +81,6 @@ Device (SIO) { IO (Decode16, 0x03F8, 0x3F8, 0x08, 0x08) IRQNoFlags () {4} }) - - Name (_PRS, ResourceTemplate () - { - StartDependentFn (0, 0) { - IO (Decode16, 0x03F8, 0x3F8, 0x08, 0x08) - IRQNoFlags () {4} - } - EndDependentFn () - }) } #endif } @@ -140,20 +108,6 @@ Scope (\_SB.PCI0) IRQ (Edge, ActiveHigh, Exclusive) {1} #endif }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) -#ifdef SIO_EC_PS2K_IRQ - SIO_EC_PS2K_IRQ -#else - IRQ (Edge, ActiveHigh, Exclusive) {1} -#endif - } - EndDependentFn () - }) } } #endif