GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/tigerlake/acpi: Update pch_hda.asl to ASL2.0 syntax 

This change updates pch_hda.asl to use ASL2.0 syntax. This
increases the readability of the ASL code.

BUG=none
BRANCH=none
TEST="BUILD for Volteer"

Signed-off-by: Venkata Krishna Nimmagadda <venkata.krishna.nimmagadda@intel.com>
Change-Id: Ia2bab6dcbac9eae76ac4258c44bb19425c8b5c80
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41799
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
This commit is contained in:
Venkata Krishna Nimmagadda 2020-05-27 14:26:03 -07:00 committed by Subrata Banik
parent 03a05b47e0
commit fc3eb1ca1d
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/soc/intel/tigerlake/acpi/pch_hda.asl
View File

@ -26,19 +26,17 @@ Device (HDAS)
*/ */
Method (_DSM, 4) Method (_DSM, 4)
{ {
If (LEqual (Arg0, ^UUID)) { If (Arg0 == ^UUID) {
/* /*
* Function 0: Function Support Query * Function 0: Function Support Query
* Returns a bitmask of functions supported. * Returns a bitmask of functions supported.
*/ */
If (LEqual (Arg2, Zero)) { If (Arg2 == 0) {
/* /*
* NHLT Query only supported for revision 1 and * NHLT Query only supported for revision 1 and
* if NHLT address and length are set in NVS. * if NHLT address and length are set in NVS.
*/ */
If (LAnd (LEqual (Arg1, One), If ((Arg1 == 1) && (NHLA != 0) && (NHLL != 0)) {
LAnd (LNotEqual (NHLA, Zero),
LNotEqual (NHLL, Zero)))) {
Return (Buffer (One) { 0x03 }) Return (Buffer (One) { 0x03 })
} Else { } Else {
Return (Buffer (One) { 0x01 }) Return (Buffer (One) { 0x01 })
@ -57,9 +55,9 @@ Device (HDAS)
CreateQWordField (NBUF, ^NHLT._MAX, NMAS) CreateQWordField (NBUF, ^NHLT._MAX, NMAS)
CreateQWordField (NBUF, ^NHLT._LEN, NLEN) CreateQWordField (NBUF, ^NHLT._LEN, NLEN)
Store (NHLA, NBAS) NBAS = NHLA
Store (NHLA, NMAS) NMAS = NHLA
Store (NHLL, NLEN) NLEN = NHLL
Return (NBUF) Return (NBUF)
} }