GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel/i82801gx,ix,jx: Drop invalid GNVS update routine 

The smm_setup_structures() calls placed GNVS address into
register %ebx. Old code on i82801dx used these low memory
addresses.

Change-Id: I407b9b9fd44db027a62356e2470f6c39ed3bff49
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42426
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Kyösti Mälkki 2020-06-29 05:46:17 +03:00 committed by Patrick Georgi
parent e769bcee9a
commit fca0cba6a1
3 changed files with 9 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/southbridge/intel/i82801gx/smihandler.c
View File

@ -21,11 +21,9 @@
u16 pmbase = DEFAULT_PMBASE; u16 pmbase = DEFAULT_PMBASE;
u8 smm_initialized = 0; u8 smm_initialized = 0;
void southbridge_update_gnvs(u8 apm_cnt, int *smm_done) /* This implementation was removed since it was invalid. There will be one shared
{ approach to set GNVS pointer into SMM without the 0xEA PM Trap mentioned above. */
gnvs = *(struct global_nvs **)0x500; void southbridge_update_gnvs(u8 apm_cnt, int *smm_done) { }
*smm_done = 1;
}
int southbridge_io_trap_handler(int smif) int southbridge_io_trap_handler(int smif)
{ {

13
src/southbridge/intel/i82801ix/smihandler.c
View File

@ -14,8 +14,9 @@
struct global_nvs *gnvs; struct global_nvs *gnvs;
#endif #endif
void *tcg = (void *)0x0; /* This implementation was removed since it was invalid. There will be one shared
void *smi1 = (void *)0x0; approach to set GNVS pointer into SMM without the 0xEA PM Trap mentioned above. */
void southbridge_update_gnvs(u8 apm_cnt, int *smm_done) { }
int southbridge_io_trap_handler(int smif) int southbridge_io_trap_handler(int smif)
{ {
@ -34,14 +35,6 @@ int southbridge_io_trap_handler(int smif)
return 0; return 0;
} }
void southbridge_update_gnvs(u8 apm_cnt, int *smm_done)
{
gnvs = *(struct global_nvs **)0x500;
tcg = *(void **)0x504;
smi1 = *(void **)0x508;
*smm_done = 1;
}
void southbridge_smi_monitor(void) void southbridge_smi_monitor(void)
{ {
#define IOTRAP(x) (trap_sts & (1 << x)) #define IOTRAP(x) (trap_sts & (1 << x))

13
src/southbridge/intel/i82801jx/smihandler.c
View File

@ -15,8 +15,9 @@
u16 pmbase = DEFAULT_PMBASE; u16 pmbase = DEFAULT_PMBASE;
u8 smm_initialized = 0; u8 smm_initialized = 0;
void *tcg = (void *)0x0; /* This implementation was removed since it was invalid. There will be one shared
void *smi1 = (void *)0x0; approach to set GNVS pointer into SMM without the 0xEA PM Trap mentioned above. */
void southbridge_update_gnvs(u8 apm_cnt, int *smm_done) { }
int southbridge_io_trap_handler(int smif) int southbridge_io_trap_handler(int smif)
{ {
@ -35,14 +36,6 @@ int southbridge_io_trap_handler(int smif)
return 0; return 0;
} }
void southbridge_update_gnvs(u8 apm_cnt, int *smm_done)
{
gnvs = *(struct global_nvs **)0x500;
tcg = *(void **)0x504;
smi1 = *(void **)0x508;
*smm_done = 1;
}
void southbridge_smi_monitor(void) void southbridge_smi_monitor(void)
{ {
#define IOTRAP(x) (trap_sts & (1 << x)) #define IOTRAP(x) (trap_sts & (1 << x))