GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/intel/glkrvp: do LPC/eSPI pad configuration at board-level 

Do LPC/eSPI pad configuration at board-level to match other platforms.
This is done by adding one missing pad to the early gpio table and
dropping the call to the soc function.

The soc code gets dropped in CB:49410.

Change-Id: I210633d4520fcfab59f68268bd7991557433ce38
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49415
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Michael Niewöhner 2020-12-21 17:09:08 +01:00
parent f31c2f2b7a
commit fccc24f063
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/intel/glkrvp/bootblock.c
View File

@ -3,7 +3,6 @@
#include <baseboard/variants.h> #include <baseboard/variants.h>
#include <bootblock_common.h> #include <bootblock_common.h>
#include <ec/ec.h> #include <ec/ec.h>
#include <intelblocks/lpc_lib.h>
#include <soc/gpio.h> #include <soc/gpio.h>
#include <variant/ec.h> #include <variant/ec.h>
@ -12,7 +11,6 @@ void bootblock_mainboard_init(void)
const struct pad_config *pads; const struct pad_config *pads;
size_t num; size_t num;
lpc_configure_pads();
pads = variant_early_gpio_table(&num); pads = variant_early_gpio_table(&num);
gpio_configure_pads(pads, num); gpio_configure_pads(pads, num);
mainboard_ec_init(); mainboard_ec_init();

1
src/mainboard/intel/glkrvp/variants/baseboard/gpio.c
View File

@ -236,6 +236,7 @@ const struct pad_config * __weak variant_gpio_table(size_t *num)
static const struct pad_config early_gpio_table[] = { static const struct pad_config early_gpio_table[] = {
PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_177, UP_20K, DEEP, NF1), /* SMB_CLK */ PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_177, UP_20K, DEEP, NF1), /* SMB_CLK */
PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_178, UP_20K, DEEP, NF1), /* SMB_DATA */ PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_178, UP_20K, DEEP, NF1), /* SMB_DATA */
PAD_NC(GPIO_154, NONE), /* LPC_CLKRUNB -- NC for eSPI */
}; };
const struct pad_config * __weak const struct pad_config * __weak