From fda7d07b7bdb044b127ae0199af3e4c5c9401ad1 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Sun, 13 Nov 2022 12:18:05 +0100 Subject: [PATCH] mb/starlabs/starbook/kbl: Drop redundant option code MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Commit 9bbc039c457774dbeb44ea37ecc6507144d49b61 ("soc/intel/skylake: Hook up FSP hyper-threading setting to option API") already hooks up the `hyper_threading` CMOS option in SoC code, so there's no need to do it from mainboard code. Change-Id: I602452266a8465cced12454f800ea023f382ba6f Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/69522 Reviewed-by: Michael Niewöhner Reviewed-by: Sean Rhodes Reviewed-by: Felix Singer Tested-by: build bot (Jenkins) --- src/mainboard/starlabs/starbook/variants/kbl/romstage.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/mainboard/starlabs/starbook/variants/kbl/romstage.c b/src/mainboard/starlabs/starbook/variants/kbl/romstage.c index 098f753f1d..72fe9ede58 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/romstage.c +++ b/src/mainboard/starlabs/starbook/variants/kbl/romstage.c @@ -19,8 +19,4 @@ void mainboard_memory_init_params(FSPM_UPD *mupd) mem_cfg->MemorySpdPtr00 = spd_cbfs_map(6); mem_cfg->MemorySpdPtr10 = mem_cfg->MemorySpdPtr00; mem_cfg->MemorySpdDataLen = CONFIG_DIMM_SPD_SIZE; - - const uint8_t ht = get_uint_option("hyper_threading", - mupd->FspmConfig.HyperThreading); - mupd->FspmConfig.HyperThreading = ht; }