From fdcc0b39156f915cdc8ee7221fca6d8640545f25 Mon Sep 17 00:00:00 2001 From: Tristan Shieh Date: Tue, 21 Aug 2018 10:33:10 +0800 Subject: [PATCH] google/kukui: Set up GPIOs for ChromeOS Set up EC interrupt GPIO to boot depthcharge. Without this patch, depthcharge will fail to detect EC interrupt GPIO. BUG=b:80501386 BRANCH=none TEST=Boots correctly on Kukui and see in logs, that depthcharge detects EC interrupt GPIO. Change-Id: I0ec2c70c189a059219954e0384aaf98995285728 Signed-off-by: Tristan Shieh Reviewed-on: https://review.coreboot.org/28250 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Julius Werner --- src/mainboard/google/kukui/Makefile.inc | 1 + src/mainboard/google/kukui/bootblock.c | 4 ++++ src/mainboard/google/kukui/chromeos.c | 12 ++++++++++++ src/mainboard/google/kukui/gpio.h | 25 +++++++++++++++++++++++++ 4 files changed, 42 insertions(+) create mode 100644 src/mainboard/google/kukui/gpio.h diff --git a/src/mainboard/google/kukui/Makefile.inc b/src/mainboard/google/kukui/Makefile.inc index 290be4cf0e..aa6bf11812 100644 --- a/src/mainboard/google/kukui/Makefile.inc +++ b/src/mainboard/google/kukui/Makefile.inc @@ -1,4 +1,5 @@ bootblock-y += bootblock.c +bootblock-y += chromeos.c bootblock-y += memlayout.ld decompressor-y += memlayout.ld diff --git a/src/mainboard/google/kukui/bootblock.c b/src/mainboard/google/kukui/bootblock.c index d8b5c5a59d..fa51488501 100644 --- a/src/mainboard/google/kukui/bootblock.c +++ b/src/mainboard/google/kukui/bootblock.c @@ -18,10 +18,14 @@ #include #include +#include "gpio.h" + #define BOOTBLOCK_EN_L (GPIO(KPROW0)) void bootblock_mainboard_init(void) { + setup_chromeos_gpios(); + /* Turn on real eMMC. */ gpio_output(BOOTBLOCK_EN_L, 1); diff --git a/src/mainboard/google/kukui/chromeos.c b/src/mainboard/google/kukui/chromeos.c index 7f9946ae40..9184d8835d 100644 --- a/src/mainboard/google/kukui/chromeos.c +++ b/src/mainboard/google/kukui/chromeos.c @@ -15,9 +15,21 @@ #include #include +#include + +#include "gpio.h" + +void setup_chromeos_gpios(void) +{ + gpio_input_pullup(EC_IRQ); +} void fill_lb_gpios(struct lb_gpios *gpios) { + struct lb_gpio chromeos_gpios[] = { + {EC_IRQ.id, ACTIVE_LOW, -1, "EC interrupt"}, + }; + lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); } int get_recovery_mode_switch(void) diff --git a/src/mainboard/google/kukui/gpio.h b/src/mainboard/google/kukui/gpio.h new file mode 100644 index 0000000000..cb9ad24906 --- /dev/null +++ b/src/mainboard/google/kukui/gpio.h @@ -0,0 +1,25 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2018 MediaTek Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef __MAINBOARD_GOOGLE_KUKUI_GPIO_H__ +#define __MAINBOARD_GOOGLE_KUKUI_GPIO_H__ + +#include + +#define EC_IRQ GPIO(PERIPHERAL_EN1) + +void setup_chromeos_gpios(void); + +#endif