From fdf668795bc5f2351b96b876d30f66c56ccf6f2e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Sun, 10 Sep 2017 07:19:16 +0300 Subject: [PATCH] AGESA: Drop unused northbridge/common MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I8c783e966cf90c6def28d87f07903f50a11487d0 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/21476 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Aaron Durbin --- src/northbridge/amd/agesa/common/Makefile.inc | 19 ----- src/northbridge/amd/agesa/common/common.c | 81 ------------------- src/northbridge/amd/agesa/common/common.h | 30 ------- 3 files changed, 130 deletions(-) delete mode 100644 src/northbridge/amd/agesa/common/Makefile.inc delete mode 100644 src/northbridge/amd/agesa/common/common.c delete mode 100644 src/northbridge/amd/agesa/common/common.h diff --git a/src/northbridge/amd/agesa/common/Makefile.inc b/src/northbridge/amd/agesa/common/Makefile.inc deleted file mode 100644 index 07059b3fd8..0000000000 --- a/src/northbridge/amd/agesa/common/Makefile.inc +++ /dev/null @@ -1,19 +0,0 @@ -# -# This file is part of the coreboot project. -# -# Copyright (C) 2014 Sage Electronic Engineering, LLC -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; version 2 of the License. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# - -romstage-y += ../../../../device/dram/ddr3.c -romstage-y += common.c - -ramstage-y += common.c diff --git a/src/northbridge/amd/agesa/common/common.c b/src/northbridge/amd/agesa/common/common.c deleted file mode 100644 index ce86b19344..0000000000 --- a/src/northbridge/amd/agesa/common/common.c +++ /dev/null @@ -1,81 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2014 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include "AGESA.h" -#include "common.h" -#include -#include -#include - -AGESA_STATUS common_ReadCbfsSpd (UINT32 Func, UINTN Data, VOID *ConfigPtr) -{ -#ifdef __PRE_RAM__ - AGESA_READ_SPD_PARAMS *info = ConfigPtr; - size_t spd_file_length; - - if (info->MemChannelId > CONFIG_AGESA_DDR3_CHANNEL_MAX) - return AGESA_ERROR; - if (info->SocketId != 0) - return AGESA_ERROR; - if (info->DimmId != 0) - return AGESA_ERROR; - - char *spd_file; - - spd_file = cbfs_boot_map_with_leak("spd.bin", CBFS_TYPE_SPD_BIN, - &spd_file_length); - if (!spd_file) - die("file [spd.bin] not found in CBFS"); - - printk(BIOS_DEBUG, "\nCBFS SPD file length = 0x%x bytes\n", (unsigned int)spd_file_length); - - if (CONFIG_MULTIPLE_DDR_SPD) { - struct multi_spd_info *spd_info = (struct multi_spd_info *)info->Buffer; - printk(BIOS_DEBUG, "Multiple DDR SPD: using offset %d\n", spd_info->offset); - if (spd_info->offset > (spd_file_length / spd_info->size)) - printk(BIOS_EMERG, "Multiple SPD offset is greater than SPD length\n"); - else { - spd_file += spd_info->offset * spd_info->size; - spd_file_length = spd_info->size; - } - } - memcpy((char*)info->Buffer, spd_file, spd_file_length); - - u16 crc = spd_ddr3_calc_crc(info->Buffer, spd_file_length); - if (crc == 0) { - printk(BIOS_EMERG, "Error: Unable to calculate CRC on SPD\n"); - return AGESA_UNSUPPORTED; - } - if (((info->Buffer[SPD_CRC_LO] == 0) && (info->Buffer[SPD_CRC_HI] == 0)) - || (info->Buffer[SPD_CRC_LO] != (crc & 0xff)) - || (info->Buffer[SPD_CRC_HI] != (crc >> 8))) { - printk(BIOS_WARNING, "SPD CRC %02x%02x is invalid, should be %04x\n", - info->Buffer[SPD_CRC_HI], info->Buffer[SPD_CRC_LO], crc); - info->Buffer[SPD_CRC_LO] = crc & 0xff; - info->Buffer[SPD_CRC_HI] = crc >> 8; - u16 i; - printk(BIOS_SPEW, "\nDisplay the SPD"); - for (i = 0; i < spd_file_length; i++) { - if ((i % 16) == 0x00) - printk(BIOS_SPEW, "\n%02x: ",i); - printk(BIOS_SPEW, "%02x ", info->Buffer[i]); - } - printk(BIOS_SPEW, "\n"); - } - return AGESA_SUCCESS; -#else - return AGESA_UNSUPPORTED; -#endif -} diff --git a/src/northbridge/amd/agesa/common/common.h b/src/northbridge/amd/agesa/common/common.h deleted file mode 100644 index 677c768212..0000000000 --- a/src/northbridge/amd/agesa/common/common.h +++ /dev/null @@ -1,30 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2014 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#ifndef _AGESA_COMMON_H_ -#define _AGESA_COMMON_H_ - -#define SPD_CRC_HI 127 -#define SPD_CRC_LO 126 - -struct multi_spd_info { - u8 offset; // defines spd 0,1,... - u8 size; // defines spd size -}; - -AGESA_STATUS -common_ReadCbfsSpd (UINT32 Func, UINTN Data, VOID *ConfigPtr); - -#endif