From ff82accadb0bb5b1fbc43978bdd0b5f4d13e373e Mon Sep 17 00:00:00 2001 From: Rocky Phagura Date: Thu, 10 Jun 2021 09:00:30 -0700 Subject: [PATCH] soc/intel/common/block: fix storage size of HEST log address This patch fixes the storage size to reflect the proper bits instead of bytes. It was a bug in the initial HEST patch (https://review.coreboot.org/c/coreboot/+/52090), and commit ID d4db36e672644ac7f528d12c5ce3539725456085 . Also fixed the comments to properly reflect the range being used. Change-Id: I9e968bb09f1c9cd805ff1d0849551b9c2ce2e2b6 Signed-off-by: Rocky Phagura Reviewed-on: https://review.coreboot.org/c/coreboot/+/55393 Reviewed-by: Sumeet R Pawnikar Reviewed-by: Arthur Heymans Tested-by: build bot (Jenkins) --- src/soc/intel/common/block/acpi/acpi/globalnvs.asl | 2 +- src/soc/intel/common/block/include/intelblocks/nvs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/soc/intel/common/block/acpi/acpi/globalnvs.asl b/src/soc/intel/common/block/acpi/acpi/globalnvs.asl index 75215f8789..ab63a5c407 100644 --- a/src/soc/intel/common/block/acpi/acpi/globalnvs.asl +++ b/src/soc/intel/common/block/acpi/acpi/globalnvs.asl @@ -24,5 +24,5 @@ Field (GNVS, ByteAcc, NoLock, Preserve) UIOR, 8, // 0x2f - UART debug controller init on S3 resume A4GB, 64, // 0x30 - 0x37 Base of above 4GB MMIO Resource A4GS, 64, // 0x38 - 0x3f Length of above 4GB MMIO Resource - , 8, // 0x40 - 0x48 Hest log buffer (used in SMM, not ASL code) + , 64, // 0x40 - 0x47 Hest log buffer (used in SMM, not ASL code) } diff --git a/src/soc/intel/common/block/include/intelblocks/nvs.h b/src/soc/intel/common/block/include/intelblocks/nvs.h index 89b682e95e..5adbdb8550 100644 --- a/src/soc/intel/common/block/include/intelblocks/nvs.h +++ b/src/soc/intel/common/block/include/intelblocks/nvs.h @@ -26,7 +26,7 @@ struct __packed global_nvs { u8 uior; /* 0x2f - UART debug controller init on S3 resume */ u64 a4gb; /* 0x30 - 0x37 Base of above 4GB MMIO Resource */ u64 a4gs; /* 0x38 - 0x3f Length of above 4GB MMIO Resource */ - u64 hest_log_addr; /* 0x40 - 48 err log addr (used in SMM, not ASL code) */ + u64 hest_log_addr; /* 0x40 - 47 err log addr (used in SMM, not ASL code) */ }; #endif